Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carts can phase through blocks #380

Open
FireController1847 opened this issue Jul 4, 2020 · 15 comments
Open

Carts can phase through blocks #380

FireController1847 opened this issue Jul 4, 2020 · 15 comments
Labels
A. bug (traincarts) Issue is caused by a bug in TrainCarts C. help wanted More help from collaborators is needed to resolve/identify this issue

Comments

@FireController1847
Copy link

BkCommonLib version: 1.15.2-v3
TrainCarts version: 1.15.2-v2-SNAPSHOT
Spigot version: Paper 1.15.2 273

Problem or bug: Carts can phase through blocks, resulting in many redstone contraptions using carts to break entirely.

Expected behaviour: Carts are properly handled and do not phase through blocks.

Steps to reproduce: Place two rails with a block on either end. Slowly but surely push the cart into the block, eventually it will fall off the track and begin phasing through the block.

@Andre601
Copy link
Contributor

Andre601 commented Jul 4, 2020

Please use /train version to give us the actual versions (Including build)

Also, you may check your trains behaviour by shift-left clicking it and then run /train info.
This will usually list what the train would do when colliding with entities and blocks.

@FireController1847
Copy link
Author

My apologies, I had just used the versions from my previous bug report as I was reporting this in somewhat of a hurry. Now that I've taken care of the, erm, situation, here's the correct info:

BKCommonLib: 1.15.2-v4 Build 791
TrainCarts: 1.15.2-v1 Build 585 (however, in my other server where we were using the latest v2 snapshot, it was also an issue, though I can't get the exact build on that now since we've updated to 1.16 and temporarily removed TrainCarts)
Spigot: Paper 1.15.2 Build 283

Here's a short gif showing the issue
20200704233009-7c011ad592 gif-2-mp4 com

And here is the train info while the train is inside of a block:

image

@Andre601
Copy link
Contributor

Andre601 commented Jul 4, 2020

I cannot really reproduce this bug despite trying it on my own 1.15 test server with the exact same settings, so it must be something on your end...
(And yes, I changed properties to also take in entities later and that didn't change anything)
image

@FireController1847
Copy link
Author

Train_Carts.zip

Here are my configuration files. I wonder if it's something I've set somehow?

@bbayu123
Copy link
Collaborator

bbayu123 commented Jul 4, 2020

Related to #319, seems like it's not truly fixed completely.

@bbayu123 bbayu123 added the A. bug (traincarts) Issue is caused by a bug in TrainCarts label Jul 4, 2020
@bbayu123
Copy link
Collaborator

bbayu123 commented Aug 4, 2020

Can you verify using 1.16.1-v1 for BK and TC so we know whether this is still relevant or not?

@FireController1847
Copy link
Author

FireController1847 commented Aug 4, 2020

Appears to be fixed as of TrainCarts 1.16 v2 Build 698 w/ BKCommonLib 1.16 v1 Build 838, using PaperMC 1.16.1 Build 117

Further testing might need to be done on the newest v1, however.

Not sure if I changed my configuration at all, but I unfortunately don't have the time currently to test with my old config (or if it works). I don't believe I've reset my config but I recently completely reconfigured my server so I'm not sure.

@bbayu123
Copy link
Collaborator

bbayu123 commented Aug 4, 2020

I would say that result is recent enough to be called resolved, however, if you do find it reappearing, feel free to reopen this.

@bbayu123 bbayu123 closed this as completed Aug 4, 2020
@bbayu123 bbayu123 added the D. resolved (requires updating of bk/tc) Issue is resolved, and requires updating of BKCommonLib and/or TrainCarts to fix label Aug 4, 2020
@FireController1847
Copy link
Author

FireController1847 commented Nov 18, 2020

This is still apparently an issue as on BKCommonLib 2 build 944 and TrainCarts 2 build 749 on Paper 1.16.4 build 282. We have found that the issue is easier to reproduce if, instead of putting two rails, put one rail between two blocks. It will almost always phase through the blocks. At a terrible guess, I would assume that it is because of the custom collision physics modifying the hitbox to be bigger than a block? But that's a random guess.

I can't re-open the issue because you closed it, but I think it needs to be re-opened.

@bergerkiller bergerkiller reopened this Nov 18, 2020
@Andre601
Copy link
Contributor

There is no BKCommonLib 2 and TrainCarts 2.
I assume you mean the latest 1.16.4 releases?

Also, could you provide steps to reproduce this and a list of all used plugins?

@FireController1847
Copy link
Author

FireController1847 commented Nov 18, 2020

My apologies, I did mean the 1.16.4-v2 snapshots. The steps to reproduce are the same as in the original post (but, as I said use one rail instead of two). The full plugin list of my production server can be found here.

@bbayu123 bbayu123 removed the D. resolved (requires updating of bk/tc) Issue is resolved, and requires updating of BKCommonLib and/or TrainCarts to fix label Dec 23, 2020
@bbayu123
Copy link
Collaborator

Sorry for the late response, I know this has been a while, but check the latest development builds and see if it is fixed there, so I can confirm whether this is still relevant.

@FireController1847
Copy link
Author

@bbayu123 I should be able to get to it in the next couple of days, I will report back here with the status.

@FireController1847
Copy link
Author

FireController1847 commented Jun 1, 2021

Sorry for the late response, I know this has been a while, but check the latest development builds and see if it is fixed there, so I can confirm whether this is still relevant.

I had an admin look into it and it does still appear to be an issue. Sorry this took me so long, it's been a busy week.

@bbayu123 bbayu123 added the C. help wanted More help from collaborators is needed to resolve/identify this issue label Aug 25, 2021
@bbayu123
Copy link
Collaborator

Labelling issue as important since you confirmed it is still an issue, and it doesn't appear to have been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A. bug (traincarts) Issue is caused by a bug in TrainCarts C. help wanted More help from collaborators is needed to resolve/identify this issue
Projects
None yet
Development

No branches or pull requests

4 participants