Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom portal shape #78

Open
RandomMCrafter opened this issue Dec 3, 2024 · 7 comments
Open

Custom portal shape #78

RandomMCrafter opened this issue Dec 3, 2024 · 7 comments

Comments

@RandomMCrafter
Copy link

I have a non-rectangular portal in my hub, and I tried to set it up as a portal to Survival, but it wasn't being detected. For now, I changed the shape of the portal, but I hope to see support for non-rectangular portals in the future.

@bergerkiller
Copy link
Member

Nether portal right? Or water portal? For nether portal I dont think it actually checks shape - unless a config.yml option is set to check for obsidian frames. Which can be turned off if it is on.

@RandomMCrafter
Copy link
Author

I tried it with an end portal in the ground, maybe it doesn't support end portals. I haven't checked that.
Screenshot 2024-12-03 223544
Apparently, end portals can't be used but end gateways can. I used the command to get a custom portal block.

@RandomMCrafter
Copy link
Author

But if I used the command to get a custom portal item then why wouldn't it work?

@bergerkiller
Copy link
Member

Maybe the issue is different, in that vanilla doesnt fire the events for the portal anymore or something. Ill have to look into that then, there's been several weird issues with end portals.

Of course do check its not fixed with https://ci.mg-dev.eu/job/MyWorlds/321/ just in case, as there was some nonsense with the respawn event not firing

@RandomMCrafter
Copy link
Author

The issue has not been resolved in the latest build. Thank you for your help, though.

@bergerkiller
Copy link
Member

I'll try to get back to you about this, a lot of end portal related things broke with 1.21.2+, I'll just have to dive in and rewrite some stuff.

Reason it's complicated is that the server does this weird player respawning logic for end portals, and the bukkit events for it are kind of bad. With 1.21.3 it also got very buggy.

@bergerkiller
Copy link
Member

I tried this on the latest Paper 1.21.4 and Spigot 1.21.4 builds, but it works fine there. Whats the exact server version youre testing with? And what type of world is the end portal on?

Also, what does /mw endportal say in the world the end portal is at?

You can also try to see if a [portal] sign near the end portal makes it do something.

I tried a flat end portal built using /mw giveportal end item in the overworld, a flat world and end world, and they work in all. I did have to adjust /mw endportal mode default in some worlds though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants