Configurable Cache for NetherPortalSearcher.java

[thojo0]

A world specific configuration to enable/disable/change the cache lifetime + cache search range would be nice.

So basicly:

• CACHE_LIFETIME
• LOAD_LIFETIME
• the 32 and maybe the 4 too:

  MyWorlds/src/main/java/com/bergerkiller/bukkit/mw/portal/NetherPortalSearcher.java

  Line 198 in 51440de

  return dx <= 32 && dy <= 4 && dz <= 32;

• radius (because I saw the comment 😉):

  MyWorlds/src/main/java/com/bergerkiller/bukkit/mw/portal/NetherPortalSearcher.java

  Line 259 in 51440de

  int radius = 128; //TODO: Configuration?

[bergerkiller]

I don't really see the use of making these things configurable. Is there a measurable reason to do so? Keep in mind that for actual searching, it defers to Minecraft servers own search, for which paper's (per-world) portal search configuration already applies.

Searching for portals also isn't as laggy as it used to be, as nowadays that information is tracked in the POI (point of interest) files.

[bergerkiller]

The LOAD_LIFETIME might be interesting to make configurable I guess, as it reduces the number of times the chunk area in the nether/overworld load and unload as people come and go.

[thojo0]

First of all, I'm the opinion to make thinks configurable if posible.

But I try to explain what is the problem for me:
If you link 2 worlds by netherportal-linking it is posible that you exit on the wrong portal.
This is a problem in classic portal chunk loader setups.

Steps to reproduce:

1. Enter red portal in overworld
2. Go through any portal back (both working fine from nether->overworld)
3. Enter green portal in overworld in the next 5 seconds
4. You will exit the red portal in the nether
5. (You can repeat this with the other way arround to)

[bergerkiller]

I see, feels more like I need to get rid of that 32x4x32 way of caching entirely then. I'll have to fix that as using portals like this is common for nether-hub systems.

[thojo0]

Is this still in doing and planed or whats the current state?

[bergerkiller]

oh, I kinda forgot. One sec

[bergerkiller]

https://ci.mg-dev.eu/job/MyWorlds/304/

Adds a config.yml option:

# MyWorlds caches destinations for portals frequently entered to minimize lag
# When a portal block is activated near to a previously activated one, search results are reused
# The width and height control the sensitivity of matching these results
# If a wrong portal is entered because of this, you can lower these values to fix that
portalSearchMatchRadius:
  width: 32
  height: 4