Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] /cleanlight world spams cosole with errors #49

Open
Tsoccerguy3 opened this issue Dec 22, 2021 · 6 comments
Open

[BUG] /cleanlight world spams cosole with errors #49

Tsoccerguy3 opened this issue Dec 22, 2021 · 6 comments

Comments

@Tsoccerguy3
Copy link

All i did was issue the command /cleanlight world . The server is still running and a /cleanlight status is still displaying its progress . IDK what its doing . Its spamming the console with errors/ See log for details . The maps were all Optimized for version 1.18.1

All the info is in the timing report
latest log.zip

https://timings.aikar.co/?id=6e04f769723f4d3d8fe1ed51cabc05e5

@bergerkiller
Copy link
Member

Made some changes, see if it helps any at eliminating the 10s+ long tick durations.

https://ci.mg-dev.eu/job/BKCommonLib/1184/
https://ci.mg-dev.eu/job/Light-Cleaner/127/

@Tsoccerguy3
Copy link
Author

The console spam is gone .Here is timing report https://timings.aikar.co/?id=d7b449d2c64341fbb8e1e34bc7381304#plugins .

@bergerkiller
Copy link
Member

its unlikely to get better than that - there is no safe way to read block data in an asynchronous fashion. Not safely anyway...

@Tsoccerguy3
Copy link
Author

Do you have any recommendations to further optimize the server while running /cleanlight world .

Not sure why but all the worlds that I migrated over to 1.18.1 , all work well. The light on all the worlds are set at its highest brightness , no dark areas and no shadows . My guess is that the light in each block needs a reset. Likely just need to run /cleanlight world just once on each map

@bergerkiller
Copy link
Member

bergerkiller commented Dec 22, 2021

The world command is kind of extreme and I generally don't recommend people use it on a live server, let alone more than once. So yeah, run it once, and if new bugs ever show up do a local fixup there.

Do note that a worldwide clean can result in new chunks being generated at the very edges of the world, so if that was carefully trimmed before, thatll have to be done again.

@Tsoccerguy3
Copy link
Author

WorldBorder has the /wb trim command , that i will run after I'm done . I will find out if this also has the effect of generating content below y=0 . This will also speed up the server if the worldgen is not constantly running. Thanks . I will keep you posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants