-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all): update cosmos-sdk deps #2172
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2172 +/- ##
===========================================
+ Coverage 26.34% 40.42% +14.07%
===========================================
Files 361 4 -357
Lines 16297 47 -16250
Branches 12 12
===========================================
- Hits 4294 19 -4275
+ Misses 11732 28 -11704
+ Partials 271 0 -271
|
06763eb
to
dfdfec4
Compare
06c093e
to
617db4e
Compare
617db4e
to
760e690
Compare
} | ||
|
||
// CoreKVStore is a wrapper of Core/Store kvstore interface | ||
// Remove after https://github.com/cosmos/cosmos-sdk/issues/14714 is closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cosmos sdk PR has been merged so all of this can be dropped
Took the following steps:
replace
clauses to a cosmos-sdk dep to a local version of the repo holding main branchgo mod tidy
in each module to cleanup deps:cosmossdk.io/x/auth
is not a module anymore so dropped referencescosmossdk.io/x/bankX
andcosmossdk.io/x/staking
depsgo mod tidy
pass with no changes, moved to unlocking compilation:kvStoreService
struct in favour ofruntime.NewKVStoreService(storeKey)
methodgo work sync
cosmossdk.io/store
andcosmossdk.io/store/v2
ProvideKVStoreService
function (now in cosmos-sdk)TODO:
genesis add-premined-deposit
fails due to bls serialization issues