Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We may want to pass a net.Listener to .Serve #35

Open
reedobrien opened this issue Oct 25, 2017 · 2 comments
Open

We may want to pass a net.Listener to .Serve #35

reedobrien opened this issue Oct 25, 2017 · 2 comments

Comments

@reedobrien
Copy link
Contributor

So we can have more control over KeepAliveTimeout.
@reedobrien
Copy link
Contributor Author

with https://golang.org/src/net/http/server.go?s=94483:94959 to shorten keepalive timeouts

@reedobrien
Copy link
Contributor Author

We're now passsing a listener but arent' setting a keep-alive timeout yet. We can review this after it runs in production for a while and then decide if we think we need to set keep-alive deadlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reedobrien