Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite in C/C++ #2

Open
benyamindsmith opened this issue Aug 27, 2024 · 3 comments
Open

Rewrite in C/C++ #2

benyamindsmith opened this issue Aug 27, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@benyamindsmith
Copy link
Owner

No description provided.

@benyamindsmith benyamindsmith added enhancement New feature or request help wanted Extra attention is needed labels Nov 22, 2024
@serkor1
Copy link

serkor1 commented Jan 13, 2025

Hi @benyamindsmith

I was browsing the "help wanted" tag, and I saw this - your library is already built on {igraph} which uses C++ as a back-end so is the issue still relevant? If not - what is your goal? Do you want to remove the dependency on {igraph} by rewriting everything in C++, or what?

Best,

@benyamindsmith
Copy link
Owner Author

Hi @serkor1,

Thanks for checking out the package!

There is definite work help wanted with rewriting the cluster_degree_betweennness function. The reason for this is based on the fact that the R code makes use of R functions and other packages which I believe could be avoided if written in C++.

The only caveat is that I've found trying to develop with the igraph C library directly a challenge.

I think rewriting the function using C/C++ will also help solve #1 .

Let me know what you think!

@serkor1
Copy link

serkor1 commented Jan 14, 2025

Ok, I get the idea. I havent studied the source code of {igraph} but using the library directly should give more flexibility. So Id guess it would solve #1.

I will take a crack at it at some point after I have submitted my package to CRAN.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants