Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Operator to get contents of commit files #288

Closed
sahansk2 opened this issue Aug 14, 2020 · 1 comment · Fixed by #301
Closed

Update Operator to get contents of commit files #288

sahansk2 opened this issue Aug 14, 2020 · 1 comment · Fixed by #301
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sahansk2
Copy link
Contributor

We'd like to have a common method to get the contents of a file in a commit, something like

def commit_content(self, commit, filepath)

since this is pretty crucial for level development in #238.

commit could support taking a Commit object, or a string commit-ish.

filepath should support taking Path objects and string representations of paths.

@benthayer benthayer added the enhancement New feature or request label Aug 14, 2020
@benthayer
Copy link
Owner

This is pretty similar to the implementation of #286 .

We should also be wary of reading the data stream, which can only be read from once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants