You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are trying to have the Summary table always appear - even after an alert-threshold is exceeded.
We use this action to perform benchmarks on several os and device types in a matrix. This splits our benchmarks into separate jobs for each ${{ matrix.os }}-${{ matrix.device }}.
The Summary does not appear for devices where the alert-threshold is exceeded, even when fail-on-alert: false is set and summary-always: true is enabled.
This is true whether comment-on-alert is set or not, and even when we set a very high fail-threshold to ensure it is not using the alert-threshold value by default and make sure that the job does not fail.
After testing several different ways, it looks like the action is not set up to create a summary table at all if a performance alert occurs.
Alerts are currently generated by throwing an exception. This means that
all code that comes after that exception is skipped, including generating
the Action summary.
We can easily fix this, by generating the summary first.
Longer term, we might want to reconsider the code style here.
An exception should model something exceptional happening in our code.
Seeing bad benchmark numbers is not exceptional. It's what this tool is
supposed to handle.
Closesbenchmark-action#254
We are trying to have the Summary table always appear - even after an
alert-threshold
is exceeded.We use this action to perform benchmarks on several
os
anddevice
types in a matrix. This splits our benchmarks into separate jobs for each${{ matrix.os }}-${{ matrix.device }}
.The Summary does not appear for devices where the
alert-threshold
is exceeded, even whenfail-on-alert: false
is set andsummary-always: true
is enabled.This is true whether
comment-on-alert
is set or not, and even when we set a very highfail-threshold
to ensure it is not using thealert-threshold
value by default and make sure that the job does not fail.After testing several different ways, it looks like the action is not set up to create a summary table at all if a performance alert occurs.
The text was updated successfully, but these errors were encountered: