Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoped API keys #262

Open
epompeii opened this issue Dec 11, 2023 · 3 comments
Open

Add scoped API keys #262

epompeii opened this issue Dec 11, 2023 · 3 comments

Comments

@epompeii
Copy link
Member

epompeii commented Dec 11, 2023

Right now tokens are unscoped.
Add scoped tokens and also make them only available at the time of creation.

The Pereto solution to this would be having a single toggle that is just for CI (and likely make this selected by default).
This would only allow for any GET queries and POST for all dimensions (Branches, Testbeds, Benchmarks, and Measures) and Reports. That is the minimum set of permissions required to run in CI.

It's likely anything past that would only make sense down the road as a Plus feature.

@epompeii
Copy link
Member Author

These scoped API tokens should also be revokable. Currently, all API tokens are non-revocable.

@epompeii
Copy link
Member Author

epompeii commented Jul 22, 2024

Currently, the API tokens are tied to a users email. This means if a user changes their email, their API tokens still appear however they will no longer be valid. The new API tokens should be tied to the user's UUID to avoid this issue.

However for testing purposes, we will still want to be able to have an API token that is set to the users email and not their UUID.

@epompeii
Copy link
Member Author

epompeii commented Sep 3, 2024

Consider using API keys instead of API tokens. The difference being that an API key is just a simple identifier, which will fit better with the prefixed IDs. For example: key_abcd1234

@epompeii epompeii changed the title Add scoped API tokens Add scoped API keys Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant