Add Cached newtype #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristano8
force-pushed
the
cached-newtype
branch
from
96c8ee1 to
db676c0
Compare
Tristano8
force-pushed
the
cached-newtype
branch
from
db676c0 to
ff58626
Compare
There was a problem hiding this comment.
Couple more nits; also I'd like @lrworth to have a chance to give his OPINONION.
Co-authored-by: JackKelly-Bellroy <[email protected]>
There was a problem hiding this comment.
I am happy with this now, but I'd really like @lrworth to weigh in, since it's a lib that he adopted.
lrworth
reviewed
Sep 21, 2023
There was a problem hiding this comment.
This gives a better API regardless of the reason, thanks @Tristano8 and @JackKelly-Bellroy.
lrworth
reviewed
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the proposal in #14
Closes #11