Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Mount relative local paths in docker command args #2082

Conversation

sarayourfriend
Copy link
Contributor

Fixes #2081.

Very much still WIP and ideation, and almost completely unverified, but wanted to push the branch into a draft PR to get things moving.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@sarayourfriend
Copy link
Contributor Author

I have a feeling the particular approach in 50feda0 is non-viable. It is not necessarily a safe assumption that any local relative path in command arguments to execute inside a Docker container which matches a real local relative path on the host should be transformed, especially if, for example, --workdir is being changed and the path is meant to refer to a known path in the container which "just so happens" to match one on the host.

I think the solution must constrain itself to the specific inputs known to potentially contain local relative paths, requires and requirement_installer_args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support path references external to sources for Docker builds in requires and requirement_installer_args
1 participant