Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOR: support ETH address (0xeee...ee) #587

Closed
gmbronco opened this issue Dec 14, 2023 · 4 comments · Fixed by #597
Closed

SOR: support ETH address (0xeee...ee) #587

gmbronco opened this issue Dec 14, 2023 · 4 comments · Fixed by #597
Milestone
Deprecate API v2

Comments

@gmbronco
Copy link
Contributor 

{
  sorGetSwaps(
    swapType: EXACT_IN
    tokenIn: "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"
    tokenOut: "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2"
    swapAmount: "1"
    chain: MAINNET
    swapOptions: { maxPools: 0 }
  ) {
    returnAmount
  }
}

throws: Missing token from tokenService 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee
@gmbronco gmbronco modified the milestone: Deprecate API v2 Dec 14, 2023
@gmbronco gmbronco added SOR and removed SOR labels Dec 14, 2023
@gmbronco
Copy link
Contributor Author

daniel: should never do that path through the SOR
the frontend should just change to wrap/unwrap

@gmbronco gmbronco reopened this Dec 14, 2023
@gmbronco
Copy link
Contributor Author

gmbronco commented Dec 14, 2023 •
edited
Loading

We should be using NATIVE_ASSETS as input / output tokens

https://github.com/balancer/b-sdk/blob/main/src/utils/constants.ts/#L167

@gmbronco
Copy link
Contributor Author

gmbronco commented Dec 14, 2023 •
edited
Loading

fixed by #597

@gmbronco gmbronco mentioned this issue Dec 14, 2023
Merged
@gmbronco gmbronco linked a pull request Dec 14, 2023 that will close this issue
native asset support, fixes: #587 #597
Merged
franzns added a commit that referenced this issue Dec 14, 2023
@franzns
Merge pull request #597 from beethovenxfi/fix/sor
dd2c31a 
native asset support, fixes: #587
@sentry-io Sentry.io
Copy link

sentry-io bot commented Dec 14, 2023

Sentry issue: BACKEND-V3-BALANCER-152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Deprecate API v2
Development

Successfully merging a pull request may close this issue.

native asset support, fixes: #587 beethovenxfi/beethovenx-backend
1 participant
@gmbronco