Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order - /order #574

Open
Tracked by #573
franzns opened this issue Dec 13, 2023 · 4 comments
Open
Tracked by #573

Order - /order #574

franzns opened this issue Dec 13, 2023 · 4 comments
Assignees

Comments

@franzns
Copy link
Contributor

franzns commented Dec 13, 2023

Endpoint for aggregator integrations as described here https://docs.balancer.fi/guides/API/usage.html#order-endpoint

@franzns franzns added this to the Deprecate API v2 milestone Dec 13, 2023
@gmbronco
Copy link
Contributor

gmbronco commented Dec 13, 2023

In the logs it shows that in the last month /order was called 81 times on Monday 11th of Dec between 6 and 7.30am

@franzns
Copy link
Contributor Author

franzns commented Dec 13, 2023

Alright, we still want to migrate as it can be used for aggregators to integrate, namely mean finance asked for it specifically for gnosis

@franzns
Copy link
Contributor Author

franzns commented Dec 20, 2023

@franzns
Copy link
Contributor Author

franzns commented Jan 8, 2024

This endpoint might actually pose a trust issue: If the API is compromised, they just execute txn data. We might want to send them txn attributes/params instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants