Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/Max Filter bounds #372

Open
obr42 opened this issue Jan 17, 2023 · 0 comments
Open

Min/Max Filter bounds #372

obr42 opened this issue Jan 17, 2023 · 0 comments
Labels
code smell Not good, but not so bad it's a bug

Comments

@obr42
Copy link
Contributor

obr42 commented Jan 17, 2023

The using the Accessibility Insights for Web extension, the accessible name for the min/max filter inputs are descriptions of what the min or max are. While helpful, just having Min (0) doesn't do much for the user as a name - either add the label/title in there or make the label the name and move that text as the aria-description. The way the accessible name is written makes me think there is supposed to be a bounds set on the min/max properties i.e. Min (1) would make me think the minimum value for that field is 1, however there are no restriction bounds put on the input fields. Can min errors be -1? Is the number instead supposed to be the value of the filter - if so that should be in the description not the name.

If the input is set to 0 it comes up as undefined on the filter.

@obr42 obr42 added the code smell Not good, but not so bad it's a bug label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code smell Not good, but not so bad it's a bug
Projects
None yet
Development

No branches or pull requests

1 participant