Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-execute fails if command has a bytes argument #346

Open
jlrpnbbngtn opened this issue Jan 10, 2023 · 1 comment
Open

Re-execute fails if command has a bytes argument #346

jlrpnbbngtn opened this issue Jan 10, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jlrpnbbngtn
Copy link
Contributor

Refer to echo_md5sum e.g. When the component displaying the form encounters a command that contains a bytes object (i.e. file upload), it doesn't know what to do with the passed-in request and crashes.

@jlrpnbbngtn jlrpnbbngtn self-assigned this Jan 10, 2023
@jlrpnbbngtn jlrpnbbngtn added the bug Something isn't working label Jan 10, 2023
@jlrpnbbngtn
Copy link
Contributor Author

jlrpnbbngtn commented Jan 11, 2023

After some team deliberation, we've decided not to support re-execute for commands that have bytes arguments. Hence, this issue is now to inactive the re-execute button in those cases.

@jlrpnbbngtn jlrpnbbngtn removed their assignment Jan 11, 2023
@obr42 obr42 added this to the release-1.0.1 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants