Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCR simulation should have circularity as an aspect of the sequence itself, not of the entire function #225

Open
Koeng101 opened this issue Nov 13, 2021 · 3 comments
Labels
easy A quick and easy fix! enhancement New feature or request medium priority The default priority for a new issue. stale

Comments

@Koeng101
Copy link
Contributor

PCR simulation should have circular as a attribute of the sequence getting input itself, not of the entire function.

@carreter
Copy link
Collaborator

Do we want to create a Sequence struct to be reused across packages that holds whether or not the sequence is circular?

@Koeng101
Copy link
Contributor Author

Do we want to create a Sequence struct to be reused across packages that holds whether or not the sequence is circular?

Probably. We have something like that in clone https://github.com/TimothyStiles/poly/blob/main/clone/clone.go but perhaps we need to have it in a higher level package. On that note, I should probably put a issue in on cloning of the things I want to fix

@carreter carreter added enhancement New feature or request easy A quick and easy fix! medium priority The default priority for a new issue. labels Sep 16, 2023
@carreter carreter added this to the v1.0 milestone Sep 23, 2023
@carreter carreter removed this from the v1.0 milestone Sep 23, 2023
Copy link

github-actions bot commented Dec 3, 2023

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy A quick and easy fix! enhancement New feature or request medium priority The default priority for a new issue. stale
Projects
None yet
Development

No branches or pull requests

2 participants