Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix - To Main] DESENG 665: Fix MET-web CI build errors #2557

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

NatSquared
Copy link
Contributor

Issue #: 🎟️ DESENG-665

Description of changes:

  • Hotfix Fix MET-web CI build errors
    • Update the npm install command in CI for the web app to use --legacy-peer-deps, resolving a dependency issue that was causing the build to fail

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

sonarcloud bot commented Jul 17, 2024

@NatSquared NatSquared marked this pull request as ready for review July 17, 2024 17:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (a5d65be) to head (4f81ad5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2557   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         609      609           
  Lines       21959    21959           
  Branches     1711     1711           
=======================================
  Hits        16681    16681           
  Misses       5015     5015           
  Partials      263      263           
Flag Coverage Δ
metweb 64.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@NatSquared NatSquared merged commit 9ce14ff into main Jul 17, 2024
8 checks passed
@NatSquared NatSquared deleted the bugfix/DESENG-665-fix-github-actions-ci-v1 branch July 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants