[To Main] Feature - DESENG-629: Add new engagement fields #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
+ Coverage 75.94% 75.97% +0.02%
==========================================
Files 603 603
Lines 21758 21781 +23
Branches 1667 1671 +4
==========================================
+ Hits 16525 16548 +23
Misses 4970 4970
Partials 263 263
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Baelx
requested changes
Jun 10, 2024
| @@ -43,7 +47,7 @@ const EngagementForm = () => { | |||
| setIsNewEngagement(!savedEngagement.id || savedEngagement.id === 0); | |||
| }, [savedEngagement]); | |||
|
|
|||
| const getErrorMessage = () => { | |||
| const getNameError = () => { | |||
There was a problem hiding this comment.
ππ»thanks for the more descriptive function name
| Engagement Date | ||
| </BodyText> | ||
| <BodyText size="small"> | ||
| Specify the date range for the public comment period, during which the public may provide |
| @@ -548,7 +558,10 @@ export const EngagementTabsContextProvider = ({ children }: { children: React.Re | |||
| status_block: surveyBlockList, | |||
| }); | |||
|
|
|||
| console.log('Engagement saved:', engagement); | |||
| if (!isNewEngagement) { | ||
| console.log('Updating engagement settings...'); |
|
Baelx
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: ποΈ DESENG-629
Description of changes:
sponsor_name,cta_message, andcta_urlto the engagement modelBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).