-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[To Main] Fix for issue of null appearing in public URLs #2529
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
=======================================
Coverage 75.99% 75.99%
=======================================
Files 619 619
Lines 22096 22094 -2
Branches 1702 1702
=======================================
- Hits 16792 16791 -1
+ Misses 5039 5038 -1
Partials 265 265
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few comments to checkout
widgetId?: string; | ||
} | ||
|
||
const withLanguageParam = <P extends object>(Component: ComponentType<P>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments may be added to explain the purpose of this HOC.
Quality Gate passedIssues Measures |
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-625
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).