Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Fix for issue of null appearing in public URLs #2529

Merged
merged 4 commits into from
May 31, 2024

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-625

Description of changes:

  • Removed language from URLs other than engagement/survey links
  • Fixed the issue of null appearing in public URLs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.99%. Comparing base (2b853c6) to head (20a371a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   75.99%   75.99%           
=======================================
  Files         619      619           
  Lines       22096    22094    -2     
  Branches     1702     1702           
=======================================
- Hits        16792    16791    -1     
+ Misses       5039     5038    -1     
  Partials      265      265           
Flag Coverage Δ
metapi 87.88% <ø> (ø)
metweb 64.91% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/config.py 97.33% <ø> (ø)
...web/src/components/engagement/view/SurveyBlock.tsx 81.08% <ø> (ø)
met-web/src/components/landing/EngagementTile.tsx 76.56% <100.00%> (ø)
met-web/src/routes/NotFound.tsx 80.00% <ø> (-1.25%) ⬇️
met-web/src/services/userService/index.ts 24.09% <100.00%> (+0.28%) ⬆️
...ement/view/widgets/Subscribe/FormSignUpSection.tsx 64.70% <0.00%> (ø)
...t-web/src/components/publicDashboard/Dashboard.tsx 70.49% <50.00%> (ø)

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review May 29, 2024 20:02
Copy link
Collaborator

@ratheesh-aot ratheesh-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few comments to checkout

widgetId?: string;
}

const withLanguageParam = <P extends object>(Component: ComponentType<P>) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments may be added to explain the purpose of this HOC.

met-web/src/routes/LanguageParam.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@VineetBala-AOT VineetBala-AOT merged commit 0e58785 into main May 31, 2024
15 checks passed
@NatSquared NatSquared deleted the feature/deseng-625 branch June 26, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants