Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if the file is null it will throw a nullPointerException #164

Open
alexjoybc opened this issue Sep 30, 2019 · 1 comment
Open

if the file is null it will throw a nullPointerException #164

alexjoybc opened this issue Sep 30, 2019 · 1 comment

Comments

@alexjoybc
Copy link
Contributor

jrcc-document-access-libs/jrcc-access-spring-boot-autoconfigure/src/main/java/ca/bc/gov/open/jrccaccess/autoconfigure/plugins/http/DocumentInterceptor.java

Line 23 in abcd75a

MDC.put(Constants.MDC_KEY_FILENAME,file.getOriginalFilename());

when the file is null, it throws a nullPointerException, we should handle that case better
peggy-gov-bc-ca added a commit to peggy-gov-bc-ca/jrcc-document-access-libs that referenced this issue Sep 30, 2019
@peggy-gov-bc-ca
Process issue bcgov#164
23b1c3f
alexjoybc added a commit that referenced this issue Jan 9, 2020
@alexjoybc
Merge pull request #165 from peggy-gov-bc-ca/httpFileNull
cf8f5b3 
Process issue #164
@akroon3r
Copy link

akroon3r commented Jan 9, 2020

@alexjoybc has this issue been resolved with the commit listed above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akroon3r @alexjoybc