Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reg\Transfers - Edit mode of Transfer form #2447

Open
24 tasks
andrea-williams opened this issue Nov 6, 2024 · 6 comments
Open
24 tasks

Reg\Transfers - Edit mode of Transfer form #2447

andrea-williams opened this issue Nov 6, 2024 · 6 comments
Labels
Blocked Estimation Tickets that need to be estimated User Story

Comments

@andrea-williams
Copy link
Contributor

andrea-williams commented Nov 6, 2024

Blocked by #2427 , #1949

Description:

As an internal user, I need to be able to edit a Transfer event if the status is "To be transferred" (i.e., the effective date of transfer is still in the future)

Acceptance Criteria:

Given I am an internal user
When I look at a Transfer (#1713 ) with a status of "To be transferred"
Then it is in disabled mode, and I have the option to edit certain fields by clicking the "Edit Details" button

I also see a "Cancel transfer button"
Given that I clicked "Cancel transfer"
A confirmation modal pops up.
Wireframe

Given that I clicked edit details

  • the form is enabled
  • the "edit details" button changes to "Transfer Entity"
  • the back button changes to "cancel" (so I know I can cancel changes)

Wireframe

Development Checklist:

  • at the bottom of the page there is a "Cancel Transfer" button that will cancel the entire transfer event
  • fields that should be editable: "Effective date of transfer", Facilities dropdown (if applicable), Operation dropdown (if applicable)
  • fields that should NOT be editable: "Current operator", "Select the new operator", "What is being transferred?"
  • to be decided by devs: should "Select the new operation this facility will be allocated to" be editable or not?
  • Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

  • User story is included
  • User role and type are identified
  • Acceptance criteria are included
  • Wireframes are included (if required)
  • Design / Solution is accepted by Product Owner
  • Dependencies are identified (technical, business, regulatory/policy)
  • Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

  • Acceptance criteria are tested by the CI pipeline
  • UI meets accessibility requirements
  • Configuration changes are documented, documentation and designs are updated
  • Passes code peer-review
  • Passes QA of Acceptance Criteria with verification in Dev and Test
  • Ticket is ready to be merged to main branch
  • Can be demoed in Sprint Review
  • Bugs or future work cards are identified and created
  • Reviewed and approved by Product Owner

Blocked By/Blocking

Notes:

@andrea-williams
Copy link
Contributor Author

@zoeyli-46 it would probably be helpful if we were to have a separate wireframe for Transfers when they're being edited.

@zoeyli-46
Copy link

I created a wireframe, and added some additional AC. Let me know what you think! @andrea-williams

@andrea-williams
Copy link
Contributor Author

thanks @zoeyli-46 ! Just noting that when the page is in Edit mode, we'll need to add another button so that users can entirely cancel the transfer if needed. But if you're super busy with other things don't worry about the wireframe - I think we can get by without it.

@zoeyli-46
Copy link

Added in AC x wireframe which includes cancelling the transfer button

@patrickisaac patrickisaac added the Estimation Tickets that need to be estimated label Nov 7, 2024
@Sepehr-Sobhani
Copy link
Contributor

Should we hide the edit button when the status is set to "Transferred"?

@andrea-williams
Copy link
Contributor Author

Should we hide the edit button when the status is set to "Transferred"?

definitely. Once the Transfer has taken place, editing should not be an option.

@BCerki BCerki added the Blocked label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Estimation Tickets that need to be estimated User Story
Projects
None yet
Development

No branches or pull requests

6 participants