Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building instructions #57

Open
OmniTroid opened this issue Feb 12, 2023 · 3 comments
Open

Add building instructions #57

OmniTroid opened this issue Feb 12, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@OmniTroid
Copy link
Contributor

Currently, there are no instructions on how to build the markdown files into the html pages displayed on the webpage. It's hard to make good change suggestions without being able to build this locally and seeing the change before proposing them.

@OmniTroid OmniTroid added the documentation Improvements or additions to documentation label Feb 12, 2023
@laurensgroeneveld
Copy link
Contributor

This is a limitation with the current setup based on https://github.com/bcc-code/bcc-documentation-base. The documentation isn't built from this repository, as VuePress is not a dependency. Rather, we copy the docs folder over to the base repository and build from there.

The benefit is that it's very easy to deploy documentation, as only a GitHub action needs to be added. There is no need to include VuePress and any plugins as a dependency.

The downside is that it's currently impossible to view a local preview from this repository. My workflow in that case has been copy over the files to a local checkout of the documentation-base repository, and run that one locally, and then copy the files back once I'm finished. This works, but isn't a nice user experience. I think this can be partially alleviated with having branch deploy previews as mentioned #67, but that still doesn't enable you to run the website locally.

So perhaps we should have a discussion on changing this setup, as it might limit us too much. We could for example also treat this repository different from the other ones since this one is intended as a full website rather than documentation attached to a repo with other code.

@jacobe
Copy link
Contributor

jacobe commented Feb 13, 2023

So perhaps we should have a discussion on changing this setup, as it might limit us too much. We could for example also treat this repository different from the other ones since this one is intended as a full website rather than documentation attached to a repo with other code.

I think this repo is a bit different, yes, since it's also the "root" website of all the other docs sites. Being able to spin it up locally would be great ❤️

@laurensgroeneveld
Copy link
Contributor

I created an issue in the documentation-base repository to discuss on how to solve the current shortcomings: bcc-code/bcc-documentation-base#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants