Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Buffering configuration for android #2

Open
andreasgangso opened this issue Aug 3, 2023 · 7 comments
Open

Feature: Buffering configuration for android #2

andreasgangso opened this issue Aug 3, 2023 · 7 comments
Labels
android Needs changes on Android good first issue Good for newcomers

Comments

@andreasgangso
Copy link
Member

This is a good first issue.

  1. Create a class in playback_platform_pigeon.dart (see pigeons readme), something similar to [betterplayers BufferingConfiguration], something similar to betterplayers BufferingConfiguration
  2. Pass it as argument to newPlayer() because you probably can't change it for an existing exoplayer.
  3. ExoPlayerController just needs to setLoadControl() with the values. Something like this: https://github.com/jhomlala/betterplayer/blob/f6a77cf6fbb515f01aa9fb459b2ee739de3e724c/android/src/main/kotlin/com/jhomlala/better_player/BetterPlayer.kt#L101
@andreasgangso andreasgangso added good first issue Good for newcomers enhancement New feature or request labels Aug 3, 2023
@andreasgangso andreasgangso changed the title Buffering configuration Feature: Buffering configuration Aug 3, 2023
@andreasgangso andreasgangso changed the title Feature: Buffering configuration Feature: Buffering configuration for android Aug 3, 2023
@andreasgangso andreasgangso added the android Needs changes on Android label Aug 9, 2023
@sudhanshugairola

This comment was marked as off-topic.

@andreasgangso

This comment was marked as off-topic.

@sudhanshugairola

This comment was marked as off-topic.

@sudhanshugairola

This comment was marked as off-topic.

@andreasgangso

This comment was marked as off-topic.

@sudhanshugairola

This comment was marked as off-topic.

@sudhanshugairola

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Needs changes on Android good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants