We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to #540
As mentioned in the Typhoeus' doc, the effective_url method should return a string: https://github.com/typhoeus/typhoeus/blob/de61860fecec32b58e150e63219d1a4062a77855/lib/typhoeus/response/informations.rb#L181
Currently in webmock, an Addressable::URI object is returned
The fix would be to replace
webmock/lib/webmock/http_lib_adapters/typhoeus_hydra_adapter.rb
Line 101 in bfc8206
:effective_url => request_signature.uri.to_s
The text was updated successfully, but these errors were encountered:
Furthermore, the default port (either 80 or 443 depending on the http/s used) is returned, which screw up specs a bit :/
Sorry, something went wrong.
Implemented a simple PR here to fix this: #869
No branches or pull requests
Related to #540
As mentioned in the Typhoeus' doc, the effective_url method should return a string: https://github.com/typhoeus/typhoeus/blob/de61860fecec32b58e150e63219d1a4062a77855/lib/typhoeus/response/informations.rb#L181
Currently in webmock, an Addressable::URI object is returned
The fix would be to replace
webmock/lib/webmock/http_lib_adapters/typhoeus_hydra_adapter.rb
Line 101 in bfc8206
:effective_url => request_signature.uri.to_s
The text was updated successfully, but these errors were encountered: