Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move container components to components directory #4478

Open
jroebu14 opened this issue Oct 30, 2019 · 0 comments
Open

Move container components to components directory #4478

jroebu14 opened this issue Oct 30, 2019 · 0 comments
Labels
technical-work Technical debt, support work and building new technical tools and features
Milestone

Comments

@jroebu14
Copy link

After this issue is completed we should move all components located in the containers directory into the components directory.

The WS team's definition of a container component is basically any component that contains business logic. When all business logic is moved out of components and into getInitialData then we should relocate these components.

This will also have the added benefit of aligning with the rest of the industry's definition of a container component that is the separation of side-effects (data-fetching, state-management) from presentation. This pattern is also not recommended anymore as highlighted in this article https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0

Things to consider
Remove any reference in the code to containers e.g. MetadataContainer rename to Metadata

Related #3003

@joshcoventry joshcoventry added technical-work Technical debt, support work and building new technical tools and features and removed simorgh-core-stream labels Sep 17, 2020
@joshcoventry joshcoventry added this to the Simorgh 3.0 milestone Sep 17, 2020
@jroebu14 jroebu14 mentioned this issue Jun 18, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Development

No branches or pull requests

3 participants