Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tests are finicky #362

Open
nicholasgriffintn opened this issue Aug 11, 2023 · 2 comments
Open

[Bug]: Tests are finicky #362

nicholasgriffintn opened this issue Aug 11, 2023 · 2 comments

Comments

@nicholasgriffintn
Copy link
Member

nicholasgriffintn commented Aug 11, 2023

Describe the bug

In this test, the package failed in Node 18: https://github.com/bbc/bbc-a11y/actions/runs/5834106815/job/15822938578#step:6:207

But then, without any source code changes, it didn't: https://github.com/bbc/bbc-a11y/actions/runs/5834177510/job/15823155934

Your minimal, reproducible example

NA

Steps to reproduce

NA

Expected behavior

It should work the same way every time.

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

NA

Package version

NA

Additional context

No response

@nicholasgriffintn nicholasgriffintn changed the title [Bug]: This package does not work in Node 18 or above [Bug]: Tests are finicky Aug 11, 2023
@dgwn
Copy link
Contributor

dgwn commented Aug 11, 2023

I understood this to be intended behavior to encourage regular manual review/testing, due to the following message:

No errors found. But please remember:
"Testing shows the presence, not the absence of bugs" -- Edsger W. Dijkstra
I am only a robot. Always make time to perform manual testing using assistive
technologies like VoiceOver, JAWS and NVDA to make sure you're providing a good
user experience.

See: features/cli/display_result_summary.feature

Although if this is the case, the explanation for a failed test run could be better explained in the message.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants