Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In search of collaborator #25

Open
bazilio91 opened this issue Dec 29, 2016 · 8 comments
Open

In search of collaborator #25

bazilio91 opened this issue Dec 29, 2016 · 8 comments

Comments

@bazilio91
Copy link
Owner

Anybody wants to become a contributor/collaborator? I have no interest to support this package now (I'm on DevOps title right now). I can't track all the changes that came in webpack.v2/es6.

@Adam-Meisen
Copy link

I might be able to help, but I'm a bit confused. The version installed from npm with npm install ejs-compiled-loader is version 1.1.0. That's also the version I got from running yarn add ejs-compiled-loader@latest. However, this repository defaults to the 2.x branch. Is that intentional? Is there a reason that npm doesn't default to the 2.x branch as well?

Second, I see the 2.2.0 version still uses the include path/to/file syntax from ejs 1.x, is that just because it hasn't been updated to the newer include('path/to/file', {options}) syntax, or is that a design decision?

@bazilio91
Copy link
Owner Author

bazilio91 commented Sep 18, 2017

@Adam-Meisen there is nothing in this design we can't change. I'm looking to find some time now to setup travis or circle to automate releases for this repo and invite some more collabs. Are you still interested?

The version installed from npm with npm install ejs-compiled-loader is version 1.1.0

Looks like it is default behaviour when you do npm publish, no matter if it is 1.x or 2.x, the last one was 1.1.0

@ianwalter
Copy link

I'm interested. I would like to set up CI to get #32 and #34 squared away.

@piuccio
Copy link

piuccio commented Mar 9, 2018

I'm also interested in contributing. I use this loader in my project and it's quite useful.

As a matter of facts I forked the repo already and implemented the changes needed to support webpack@4
It's here if you want to try it out. I haven't updated the README yet.

It's published on npm as @piccio/ejs-compiled-loader version 3.0.0.

If there's interest I can make a PR. @bazilio91 let me know

@vagusX
Copy link

vagusX commented May 14, 2018

so any new progress?

@piuccio
Copy link

piuccio commented May 14, 2018

@vagusX I haven't heard from @bazilio91 but I'm using https://github.com/piuccio/ejs-compiled-loader in production and works fine for me with webpack 4

npm i @piuccio/ejs-compiled-loader

@bazilio91
Copy link
Owner Author

@piuccio this repo is still getting lots of downloads, and I have some time now to get this solved, will u join this repo to maintain it with some other guys who is interested in it and maintaining own forks?

@piuccio
Copy link

piuccio commented Apr 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants