Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade packages to use cosmos-sdk v0.47 #5

Merged
merged 7 commits into from
May 9, 2024
Merged

upgrade packages to use cosmos-sdk v0.47 #5

merged 7 commits into from
May 9, 2024

Conversation

nkitlabs
Copy link
Contributor

@nkitlabs nkitlabs commented May 9, 2024 •
edited
Loading

Implementation details

  • Upgrade version of cosmos-sdk in go-band-sdk/requester & go-band-sdk/client from 0.45.16 to 0.47.11 (refer to repo bandprotocol/chain at latest commit(b6ed5a9) in master branch)
  • Update go-band-sdk/example

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

RogerKSI
RogerKSI requested changes May 9, 2024
View reviewed changes
client/rpc.go Outdated Show resolved Hide resolved
examples/requester/configs/example_band_laozi.yaml Outdated
fee: "0.0025uband"
timeout: "10s"
request:
mnemonic: "child across insect stone enter jacket bitter citizen inch wear breeze adapt come attend vehicle caught wealth junk cloth velvet wheat curious prize panther"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please at least use the same mnemonic with the local chain here as an example.

nkitlabs and others added 2 commits May 9, 2024 11:23
@nkitlabs @RogerKSI
Update client/rpc.go
f1b6eca 
Co-authored-by: Kitipong Sirirueangsakul <[email protected]>
@nkitlabs
update mnemonic
3df5c45
@nkitlabs nkitlabs requested a review from RogerKSI May 9, 2024 04:25
@RogerKSI
Copy link
Collaborator

RogerKSI commented May 9, 2024

please also update the CHANGELOG file. However, please also add for v1.0.0 and v1.0.1

warittornc
warittornc approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@warittornc warittornc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with nit

examples/requester/example.go Outdated Show resolved Hide resolved
@RogerKSI RogerKSI merged commit 715d9d3 into main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warittornc warittornc warittornc approved these changes

@RogerKSI RogerKSI RogerKSI approved these changes

@taobun taobun Awaiting requested review from taobun

@satawatnack satawatnack Awaiting requested review from satawatnack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkitlabs @RogerKSI @warittornc