Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v1 API #9

Open
31 of 61 tasks
graywolf336 opened this issue Dec 16, 2016 · 14 comments
Open
31 of 61 tasks

Implement v1 API #9

graywolf336 opened this issue Dec 16, 2016 · 14 comments

Comments

@graywolf336
Copy link
Collaborator

graywolf336 commented Dec 16, 2016

Right now the following items need to be built out, this will serve as a living issue. When building them out, we need to be sure to build out the complete model with getters and setters along with the method on the main client.

Misc

Authentication

Chat Messages

Users

Channels

Groups

Settings

Integrations

  • Create (still in the works, so no documentation)
  • List (still in the works, so no documentation)

Livechat

@graywolf336
Copy link
Collaborator Author

@rynefagin Take a look at the above, figure we might create an issue and track our progress via it.

@rynefagin
Copy link
Contributor

Sounds good, just what we needed. Thanks @graywolf336

@graywolf336
Copy link
Collaborator Author

@rynefagin I'm going to start working on the chat apis, you good with that?

@rynefagin
Copy link
Contributor

Yes

@graywolf336
Copy link
Collaborator Author

@rynefagin I am adding pagination to the Rocket.Chat REST API for things like GET channels.list, so we will have to add pagination support however I'm not 100% certain how we should go about doing that. Any ideas?

@rynefagin
Copy link
Contributor

@graywolf336 Hmmm. One thought is to use the link header in the response which shifts the burden off of the java api to build links to the next set of results and means we don't have to include pagination data in the payload.

@graywolf336
Copy link
Collaborator Author

@rynefagin Sadly that requirement wasn't in the time frame I was allocated to build the pagination support and will be added in the future 👎

@rynefagin
Copy link
Contributor

@graywolf336 any ideas? So pagination will be provided in the body?

@graywolf336
Copy link
Collaborator Author

@rynefagin After doing some work on the rest api and pagination, only a few items are going to have them and those are the ones which list everything like the channels.list. It takes two parameters:

  • count - how many items you want to get, defaults to 50 but it is configurable per server.
  • offset - which position in the overall list of items do you want to start from, defaults to 0. We went with offset instead of pages because it is easier for other people and also allows for more flexibility when trying to get items from the server.

Does that make sense?

@graywolf336
Copy link
Collaborator Author

@rynefagin You can an invite to collaborate on this repository, click here to see the invite. I only say this, as I would like to start making reviews on pull requests required for your review to be considered official you have to be a collaborator on this repository.

@Davide95
Copy link

Are there news about implementing v1?
For what I'm reading here send/delete messages are not supported yet. Is that true?

@sscholl
Copy link

sscholl commented Jan 5, 2018

Is the API compatible with the current version of RocketChat?
Thanks!

@orrchen
Copy link

orrchen commented Jan 7, 2018

yes it is

@col-panic
Copy link
Collaborator

Working on an implementation of the Settings, see https://github.com/col-panic/rocket-chat-rest-client/tree/settingsImpl for current progress. Currently building and testing seems not possible - see #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants