Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module directories are missing in the repo #36458

Open
sahanHe opened this issue Jun 7, 2022 · 7 comments
Open

Module directories are missing in the repo #36458

sahanHe opened this issue Jun 7, 2022 · 7 comments

Comments

@sahanHe
Copy link
Contributor

sahanHe commented Jun 7, 2022

Description:
Several modules listed in settings.gradle doesn't have base directories in the repository. This results in build errors when tried to compile with third party tools like sonarcloud giving errors like following
> The base directory of the module ':ballerina-config-schema-builder' does not exist: /home/runner/work/ballerina-lang/ballerina-lang/misc/ballerina-config-schema-builder

Issue can be solved by adding following lines to the workflow

- name: Create missing module folders
        run: |
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/ballerina-formatter 
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/ballerina
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/ballerina-langlib
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/compiler-plugins
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/composer
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/debug-adapter
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/distribution/zip/nballerina-tools
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/formatter 
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/ls-extensions
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/project-api-test-artifact
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/language-server/modules/test-coverage
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/misc/testerina/modules/report-tools
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/misc/ballerina-config-schema-builder
          mkdir -p /home/runner/work/ballerina-lang/ballerina-lang/ballerina-stringutils

Steps to reproduce:

First fork the repo in to your own github organisation and register for sonarcloud. Then follow the CI/CD configuration tutorials mentioned in the sonarcloud for building with sonarqube. following line gives build error
run: ./gradlew build sonarqube --scan --no-daemon

Affected Versions:
Current version- 2201.1.0

@areebniyas
Copy link
Contributor

areebniyas commented Oct 4, 2024

Hi, can I work on this issue? And could you give me a bit more context to avoid redundancy as the lines mentioned in the issue are already added in:

- name: Create missing module folders

@areebniyas
Copy link
Contributor

areebniyas commented Oct 20, 2024

Hi @keizer619, I believe #37087 should have closed this issue a while back. Could you double check and let me know if there is anything more to be done?

@areebniyas
Copy link
Contributor

@sm1990 @gimantha Any update regarding this would be great, cheers.

@keizer619
Copy link
Member

Hi, can I work on this issue? And could you give me a bit more context to avoid redundancy as the lines mentioned in the issue are already added in:

ballerina-lang/.github/workflows/daily_build.yml

Line 95 in f436157

  • name: Create missing module folders

I'm sorry for not getting back to you sooner. In the above PR has manually created directories just to get things passed. This issue is to properly fix it from gradle project side and remove those manually creating directories in the workflow level

If you are willing to work you can continue

@keizer619
Copy link
Member

Hi @areebniyas are you working on this? If not we can open this for public

@areebniyas
Copy link
Contributor

Hi @keizer619, a bit packed. Let's open it, meanwhile whenever I get the chance will have a look.

@areebniyas areebniyas removed their assignment Dec 10, 2024
@Shadow-Devil
Copy link
Contributor

Hi @keizer619 I would like to take this issue. I already did part of it in #43668 via removing the not found modules from the settings.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

6 participants