Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited usefulness #42

Open
vemv opened this issue Feb 16, 2016 · 3 comments
Open

Limited usefulness #42

vemv opened this issue Feb 16, 2016 · 3 comments

Comments

@vemv
Copy link

vemv commented Feb 16, 2016

Hi,

I just ran i15r on an inherited project, and it runs mostly fine. Thanks for the good work!

However, I'm not sure of why would I want to run a tool that doesn't generate any yml file.

  • If I don't use --no-default, I get e.g. 1000 entries like I18n.t("users.new.name", :default => 'Name'), and I still will have to manually create 1000 entries in en.yml. Even if I do that, then I'd have to manually remove (default: 'foo') from each t call, for ensuring DRY/correctness.
  • If I use --no-default, any app will become empty/broken until you manually create 1000 entries in en.yml.

Either option is undesirable. As I see it, this gem would be only be useful if it generates a yml file as well.

Probably overwriting en.yml would be obstrusive/error-prone. However, generating a separate yml file could allow the developer to adapt it as he wishes.

Do you think you can make this happen?

For now I will be giving it a try, in my fork.

Cheers - Victor

@balinterdi
Copy link
Owner

Hey Victor,

I haven't really touched this gem for ~2 years now and I'm overwhelmed with other stuff.

I agree that creating an output yml file would make it more useful, so if you add this feature, I'll happily accept a PR and release a new gem version (if I can recall how to do that :) ).

Thank you.

@vemv
Copy link
Author

vemv commented Feb 16, 2016

No worries and thanks again for the gem. Let's see if I can implement the thing!

@balinterdi
Copy link
Owner

@ACPK Well, I wrote missing_t so I tried it but as I'd said I no longer have the ambition of implementing new features myself.

However, I'd happily review/merge in PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants