diff --git a/packages/hardhat/contracts/ConstantPricePool.sol b/packages/hardhat/contracts/ConstantPricePool.sol index 9c744e2b..fe925d8c 100644 --- a/packages/hardhat/contracts/ConstantPricePool.sol +++ b/packages/hardhat/contracts/ConstantPricePool.sol @@ -11,12 +11,11 @@ import "./vault/BalancerPoolToken.sol"; * @notice CURRENTLY A WIP. This is an example custom pool implementation used. */ contract ConstantPricePool is IBasePool, BalancerPoolToken { - constructor( IVault vault, string memory name, string memory symbol - ) BalancerPoolToken(vault, name, symbol) {} + ) BalancerPoolToken(vault, name, symbol) {} /** * @notice Execute a swap in the pool. @@ -58,18 +57,16 @@ contract ConstantPricePool is IBasePool, BalancerPoolToken { newBalance = (balancesLiveScaled18[tokenInIndex] + - invariant * (invariantRatio)) - + invariant * + (invariantRatio)) - invariant; } /** - * @notice Gets the tokens registered to a pool. - * @dev Delegated to the Vault; added here as a convenience, mainly for off-chain processes. + * @notice Gets the tokens registered to a pool. + * @dev Delegated to the Vault; added here as a convenience, mainly for off-chain processes. * @dev TODO - left blank for now, but for finished example w/ scaffoldBalancer we need to implement this correctly. - * @return tokens List of tokens in the pool - */ - function getPoolTokens() external view returns (IERC20[] memory tokens) { - - } - + * @return tokens List of tokens in the pool + */ + function getPoolTokens() external view returns (IERC20[] memory tokens) {} } diff --git a/packages/nextjs/app/pools/_components/PoolDetails.tsx b/packages/nextjs/app/pools/_components/PoolAttributes.tsx similarity index 65% rename from packages/nextjs/app/pools/_components/PoolDetails.tsx rename to packages/nextjs/app/pools/_components/PoolAttributes.tsx index 91203977..f9c11a9e 100644 --- a/packages/nextjs/app/pools/_components/PoolDetails.tsx +++ b/packages/nextjs/app/pools/_components/PoolAttributes.tsx @@ -5,7 +5,7 @@ import { Address } from "~~/components/scaffold-eth"; import { usePoolContract } from "~~/hooks/balancer"; /** - * Display a pool's contract details + * Display a pool's attritubes * @dev do we want to display any of the pool config details? -> https://docs-v3.balancer.fi/concepts/vault/onchain-api.html#getpoolconfig * * struct PoolConfig { @@ -21,7 +21,7 @@ import { usePoolContract } from "~~/hooks/balancer"; LiquidityManagement liquidityManagement; } */ -export const PoolDetails = ({ poolAddress }: { poolAddress: string }) => { +export const PoolAttributes = ({ poolAddress }: { poolAddress: string }) => { const { data: pool } = usePoolContract(poolAddress); const detailsRows = [ @@ -35,24 +35,16 @@ export const PoolDetails = ({ poolAddress }: { poolAddress: string }) => {
Pool Attributes
-
- - {/* - - - - - */} - - {detailsRows.map(({ attribute, detail }, index) => ( - - - - - ))} - -
AttributeDetails
{attribute}{detail}
+ {detailsRows.map(({ attribute, detail }, index) => ( +
+
{attribute}
+
{detail}
+
+ ))}
diff --git a/packages/nextjs/app/pools/_components/index.tsx b/packages/nextjs/app/pools/_components/index.tsx index 10210ead..7d4c6bd3 100644 --- a/packages/nextjs/app/pools/_components/index.tsx +++ b/packages/nextjs/app/pools/_components/index.tsx @@ -1,4 +1,4 @@ export * from "./PoolActions"; export * from "./PoolComposition"; -export * from "./PoolDetails"; +export * from "./PoolAttributes"; export * from "./UserLiquidity"; diff --git a/packages/nextjs/app/pools/page.tsx b/packages/nextjs/app/pools/page.tsx index 3cc594d0..8a35df34 100644 --- a/packages/nextjs/app/pools/page.tsx +++ b/packages/nextjs/app/pools/page.tsx @@ -1,7 +1,7 @@ "use client"; import { useState } from "react"; -import { PoolActions, PoolComposition, PoolDetails, UserLiquidity } from "./_components/"; +import { PoolActions, PoolAttributes, PoolComposition, UserLiquidity } from "./_components/"; import type { NextPage } from "next"; import { type Address, isAddress } from "viem"; import { ChevronDownIcon, MagnifyingGlassIcon } from "@heroicons/react/24/outline"; @@ -98,7 +98,7 @@ const Pools: NextPage = () => { -
+

{pool?.name}

@@ -113,7 +113,7 @@ const Pools: NextPage = () => {
- +
)}