From fa459f39f41486d44222a821c7a4cce41ea252ab Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Tue, 3 Sep 2024 16:15:09 +0200 Subject: [PATCH] Mellow dvstETH Rate Provider Fixes #135 --- rate-providers/MellowRateProviders.md | 12 +++++++----- rate-providers/registry.json | 14 ++++++++++++++ 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/rate-providers/MellowRateProviders.md b/rate-providers/MellowRateProviders.md index 5e0f99b..e2493d0 100644 --- a/rate-providers/MellowRateProviders.md +++ b/rate-providers/MellowRateProviders.md @@ -10,6 +10,7 @@ - [ethereum:0x3A2228C7B3Bc3A32AEa9338d0A890A5EbD7bc977](https://etherscan.io/address/0x3A2228C7B3Bc3A32AEa9338d0A890A5EbD7bc977#code) - [ethereum:0x34406A8Ee75B5af34F8920D1960AC6a5B33A47b6](https://etherscan.io/address/0x34406A8Ee75B5af34F8920D1960AC6a5B33A47b6#readContract) - [ethereum:0x2A2f1b8c02Dafc5359B8E0e8BFc138400CB6d3a1](https://etherscan.io/address/0x2A2f1b8c02Dafc5359B8E0e8BFc138400CB6d3a1#readContract) + - [ethereum:0x1a9DBa2dC3E82F53d040701F97DC0438d26A4320](https://etherscan.io/address/0x1a9DBa2dC3E82F53d040701F97DC0438d26A4320#readContract) - Audit report(s): - [Mellow LRT audits](https://docs.mellow.finance/mellow-lrt-primitive/audits) @@ -67,11 +68,12 @@ If none of these is checked, then this might be a pretty great Rate Provider! If - admin type: multisig - multisig threshold/signers: 5/8 - comment: The `ADMIN_ROLE`has the capability to add new Tvl modules, which are target of an external call. An rogue `ADMIN_ROLE`could add malicious modules potentially inflating the the price. This functionality currently resides within: [ethereum:0x9437B2a8cF3b69D782a61f9814baAbc172f72003](https://etherscan.io/address/0x9437B2a8cF3b69D782a61f9814baAbc172f72003) - - - - - + #### Decentralized Validator Token (DVstETH) + - upgradeable component: `Vault`([ethereum:0x5E362eb2c0706Bd1d134689eC75176018385430B](https://etherscan.io/address/0x5E362eb2c0706Bd1d134689eC75176018385430B)) + - admin address: [ethereum:0x81698f87C6482bF1ce9bFcfC0F103C4A0Adf0Af0](https://etherscan.io/address/0x81698f87C6482bF1ce9bFcfC0F103C4A0Adf0Af0) + - admin type: multisig + - multisig threshold/signers: 5/8 + - comment: The `ADMIN_ROLE`has the capability to add new Tvl modules, which are target of an external call. An rogue `ADMIN_ROLE`could add malicious modules potentially inflating the the price. This functionality currently resides within: [ethereum:0x9437B2a8cF3b69D782a61f9814baAbc172f72003](https://etherscan.io/address/0x9437B2a8cF3b69D782a61f9814baAbc172f72003) ### Oracles - [x] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). diff --git a/rate-providers/registry.json b/rate-providers/registry.json index 25da86f..2dc1e7c 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -1367,6 +1367,20 @@ "implementationReviewed": "0x0b75F2B048CA8517f6476316F872903920DCC8ef" } ] + }, + "0x1a9DBa2dC3E82F53d040701F97DC0438d26A4320": { + "asset": "0x5E362eb2c0706Bd1d134689eC75176018385430B", + "name": "VaultRateOracle", + "summary": "safe", + "review": "./MellowRateProviders.md", + "warnings": ["donation"], + "factory": "", + "upgradeableComponents": [ + { + "entrypoint": "0x5E362eb2c0706Bd1d134689eC75176018385430B", + "implementationReviewed": "0xe2D2E90122cb203CF1565a37ef90a256843A825A" + } + ] } }, "fantom": {