Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravita Rate Providers #202

Open
4 tasks done
Zen-Maxi opened this issue Dec 10, 2024 · 1 comment
Open
4 tasks done

Gravita Rate Providers #202

Zen-Maxi opened this issue Dec 10, 2024 · 1 comment
Assignees

Comments

@Zen-Maxi
Copy link
Collaborator

Type of Smart Contract

Rate Provider

Type of Smart Contract (if Other)

No response

Contract Source Code

0xBB22d59B73D7a6F3A8a83A214BECc67Eb3b511fE

Asset Contract Source Code

https://etherscan.io/address/0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2

Additional Links

RPL implementation https://etherscan.io/address/0x1DB1Afd9552eeB28e2e36597082440598B7F1320 and asset https://etherscan.io/address/0xD33526068D116cE69F19A9ee46F0bd304F21A51f please review both rate providers.

Protocol Documentation

https://docs.gravitaprotocol.com/gravita-docs

Protocol Audits

https://docs.gravitaprotocol.com/gravita-docs/about-gravita-protocol/audits

Terms and Conditions

  • The protocol to be integrated has been audited by at least one security firm or independent researcher.
  • If deployed, the contract & all involved downstream contracts are verified on etherscan.
  • The contract does not rely upon an EOA to supply any critical data (e.g., price).
  • If upgradeable, the contract's administrator is not an EOA.

Additional Comments & Clarifications

No response

@VVander
Copy link

VVander commented Dec 10, 2024

Hello, as the CTO for the dev team, I was asked to provide some technical context on both of these contracts (xRPL and xrETH).

  1. These contracts don't follow the ERC4626 interface perfectly (see this issue on our GH: Override maxDeposit, maxMint, maxWithdraw and maxRedeem functions in vault to comply with ERC-4626 specification nodeset-org/constellation#415). The deviations mainly relate to the view functions not correctly checking all the limitations that the write functions implement. For example, maxDeposit() does not check the sanctions list while the deposit() and mint() functions do perform this check. Some of the view functions do operate as expected, however (e.g. totalAssets()).

  2. Note that, while there are no exit fees for either contract and there is no entrance fee for xRPL, there is a .03% entrance fee for xrETH in order to prevent oracle front-running attacks.

  3. We use standard timelock controllers for admin actions like contract upgrades and certain sensitive parameter settings.

For more information on Constellation (the protocol that originated these tokens), please see the docs here.

@mkflow27 mkflow27 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants