Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add conclusion to registry #106

Closed
wants to merge 9 commits into from
Closed

Feat/add conclusion to registry #106

wants to merge 9 commits into from

Conversation

mkflow27
Copy link
Collaborator

@mkflow27 mkflow27 commented Jul 17, 2024 •
edited
Loading

Fixes Fixes #105
This pr modifies the registry file to include the conclusions from the review.

@mkflow27 mkflow27 requested a review from franzns July 17, 2024 15:09
@mkflow27 mkflow27 marked this pull request as ready for review July 18, 2024 10:57
@mkflow27 mkflow27 requested a review from danielmkm July 18, 2024 10:57
franzns
franzns approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@franzns franzns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding isAllowed looks good to me and is in line with the terminology we use for tokens.

@mkflow27
Copy link
Collaborator Author

not required

@mkflow27 mkflow27 closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzns franzns franzns approved these changes

@danielmkm danielmkm Awaiting requested review from danielmkm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summary not part of registry
2 participants
@mkflow27 @franzns