From fcae816ceaf80e5e719cc2c432b765dfeed37956 Mon Sep 17 00:00:00 2001 From: Zen-Maxi <85650601+Zen-Maxi@users.noreply.github.com> Date: Tue, 10 Dec 2024 09:08:58 -0500 Subject: [PATCH 1/3] Adding Market Rate Transformers Market Rate Transformers: - Mainnet Lido Aave wstETH (Legacy wstETH Rate + Aave Statav2 Vault) - Mainnet csUSDL - Steakhouse wUSDL vault (2 ERC4626 Vaults) - Gnosis Aave wstETH (Chainlink + Aave Statav2 Vault) Includes wUSDL raw rate provider on mainnet as well, this is identical to the Arbitrum implementation which was review several months ago. --- .../MarketRateTransformerRateProviders.md | 84 +++++++++++++++++++ rate-providers/registry.json | 72 ++++++++++++++++ rate-providers/wUSDLPaxosRateProvider.md | 11 +++ 3 files changed, 167 insertions(+) create mode 100644 rate-providers/MarketRateTransformerRateProviders.md diff --git a/rate-providers/MarketRateTransformerRateProviders.md b/rate-providers/MarketRateTransformerRateProviders.md new file mode 100644 index 0000000..fe0daa6 --- /dev/null +++ b/rate-providers/MarketRateTransformerRateProviders.md @@ -0,0 +1,84 @@ +# Rate Provider: `ERC4626RateProvider` + +## Details +- Reviewed by: @mkflow27 +- Checked by: @danielmkm +- Deployed at: + - Lido a-wstETH [ethereum:0xcdAa68ce322728FE4185a60f103C194F1E2c47BC](https://etherscan.io/address/0xcdAa68ce322728FE4185a60f103C194F1E2c47BC#code) + - csUSDL (Steakhouse) [ethereum:0x9CC54cb63E61c7D5231c506e4206Eb459250D2A7](https://etherscan.io/address/0x9CC54cb63E61c7D5231c506e4206Eb459250D2A7#code) + + - a-wstETH [gnosis:0x30EAcEC6BD250589043De026e45dc9A158C65a1F](https://gnosisscan.io/address/0x30EAcEC6BD250589043De026e45dc9A158C65a1F#readContract) + +- Audit report(s): + - [Formal Verification Report For StaticAToken](https://github.com/aave-dao/aave-v3-origin/blob/067d29eb75115179501edc4316d125d9773f7928/audits/11-09-2024_Certora_StataTokenV2.pdf) + + - [Security Reviews & Formal Verifications](https://docs.morpho.org/security-reviews/) + - [MetaMorpho Spearbit Audit](https://github.com/morpho-org/metamorpho/blob/main/audits/2023-11-14-metamorpho-cantina-managed-review.pdf) + +## Context +The ERC4626 RateProvider fetches the rate of Static Aave Tokens in terms of USDC or USDT. The exchange rate is provided by the Aave V3 `POOL` and fetched via `getReserveNormalizedIncome` from the pool and wrapped as part of the `convertToAsset` call to the `StataTokenV2`. + +The ERC4626 RateProvider fetches the rate of MetaMorpho Vault tokens in terms of the underlying asset. The exchange rate is provided via the conversion between totalAssets and totalSupply. The Morpho contract only determines the potential market parameters, assets, collaterals, beneficiary, owner, fee, and cooldown periods related to the vault curator. There are no entry or exit fees, and no time locks for users to deposit and withdraw from this vault. + +## Review Checklist: Bare Minimum Compatibility +Each of the items below represents an absolute requirement for the Rate Provider. If any of these is unchecked, the Rate Provider is unfit to use. + +- [x] Implements the [`IRateProvider`](https://github.com/balancer/balancer-v2-monorepo/blob/bc3b3fee6e13e01d2efe610ed8118fdb74dfc1f2/pkg/interfaces/contracts/pool-utils/IRateProvider.sol) interface. +- [x] `getRate` returns an 18-decimal fixed point number (i.e., 1 == 1e18) regardless of underlying token decimals. + +## Review Checklist: Common Findings +Each of the items below represents a common red flag found in Rate Provider contracts. + +If none of these is checked, then this might be a pretty great Rate Provider! If any of these is checked, we must thoroughly elaborate on the conditions that lead to the potential issue. Decision points are not binary; a Rate Provider can be safe despite these boxes being checked. A check simply indicates that thorough vetting is required in a specific area, and this vetting should be used to inform a holistic analysis of the Rate Provider. + +### Administrative Privileges +- [ ] The Rate Provider is upgradeable (e.g., via a proxy architecture or an `onlyOwner` function that updates the price source address). + +- [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). + + - [ethereum:0x775F661b0bD1739349b9A2A3EF60be277c5d2D29](https://etherscan.io/address/0x775F661b0bD1739349b9A2A3EF60be277c5d2D29#code) + - upgradeable component: `StataTokenV2` ([ethereum:0xD4fa2D31b7968E448877f69A96DE69f5de8cD23E](https://etherscan.io/address/0xD4fa2D31b7968E448877f69A96DE69f5de8cD23E#readProxyContract)) + - admin address: [ethereum:0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A](https://etherscan.io/address/0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A#code) + - admin type: Aave governance system. + - multisig timelock? YES: 24 hours. + - upgradeable component: `Pool` ([ethereum:0x87870Bca3F3fD6335C3F4ce8392D69350B4fA4E2](https://etherscan.io/address/0x87870Bca3F3fD6335C3F4ce8392D69350B4fA4E2#readProxyContract)) + - admin address: [ethereum:0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A](https://etherscan.io/address/0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A#code) + - admin type: Aave governance system. + - multisig timelock? YES: 24 hours + + + - [gnosis:0x773CDA0CADe2A3d86E6D4e30699d40bB95174ff2](https://gnosisscan.io/address/0x773CDA0CADe2A3d86E6D4e30699d40bB95174ff2#readProxyContract) + - upgradeable component: `StataTokenV2` ([gnosis:0x51350d88c1bd32Cc6A79368c9Fb70373Fb71F375](https://gnosisscan.io/address/0x51350d88c1bd32Cc6A79368c9Fb70373Fb71F375.#readProxyContract)) + - admin address: [gnosis:0x1dF462e2712496373A347f8ad10802a5E95f053D](https://gnosisscan.io/address/0x1dF462e2712496373A347f8ad10802a5E95f053D) + - admin type: Aave governance system. + - multisig timelock? YES: 24 hours. + - upgradeable component: `L2Pool` ([gnosis:0xb50201558B00496A145fE76f7424749556E326D8](https://gnosisscan.io/address/0xb50201558B00496A145fE76f7424749556E326D8#code)) + - admin address: [gnosis:0x1dF462e2712496373A347f8ad10802a5E95f053D](https://gnosisscan.io/address/0x1dF462e2712496373A347f8ad10802a5E95f053D#code) + - admin type: Aave governance system. + - multisig timelock? YES: 24 hours + +For Morpho: +- [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). + Part of the rate computation relies of `totalAssets` being calculated. This function iterates over a list of Ids. This list of Ids can be changed by the Allocator role. The potential impact has not been thoroughly investigated. There are however protections in place to protect against invalid changes such as + - `revert ErrorsLib.DuplicateMarket(id);` + - `revert ErrorsLib.InvalidMarketRemovalNonZeroCap(id);` + - `revert ErrorsLib.PendingCap(id);` + - `ErrorsLib.InvalidMarketRemovalNonZeroSupply(id);` + - `ErrorsLib.InvalidMarketRemovalTimelockNotElapsed(id);` + +See /MorphoERC4626RateProviders + +### Oracles +- [ ] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). + +- [ ] Price data is expected to be volatile (e.g., because it represents an open market price instead of a (mostly) monotonically increasing price). + +### Common Manipulation Vectors +- [ ] The Rate Provider is susceptible to donation attacks. + +## Conclusion +**Summary judgment: SAFE/USBALE** + +The Rate Providers should work well with Balancer pools. The underlying contracts have been audited and been in production for an extended period of time. The upgradeability of the underlying Aave protocol is guarded behind decentralized governance and has a minimum execution delay of 24 hours. + +Morpho: The Rate Providers should work well with Balancer pools. The underlying contracts have been audited and been in production for an extended period of time. diff --git a/rate-providers/registry.json b/rate-providers/registry.json index 9b17460..c49b304 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -1820,6 +1820,60 @@ "implementationReviewed": "0x2371e134e3455e0593363cBF89d3b6cf53740618" } ] + }, + "0x51b7F50044a2a1A9A846575Be33c00A68e0172DF": { + "asset": "0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559", + "name": "ERC4626RateProvider", + "summary": "safe", + "review": "./wUSDLPaxosRateProvider.md", + "warnings": [], + "factory": "0xe548a29631f9e49830be8edc22d407b2d2915f31", + "upgradeableComponents": [ + { + "entrypoint": "0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559", + "implementationReviewed": "0x2954c85e7e2b841d0e9a9fdcc09dac1274057d71" + }, + { + "entrypoint": "0xbdC7c08592Ee4aa51D06C27Ee23D5087D65aDbcD", + "implementationReviewed": "0x752d55d62a94658eac08eae42deda902b69b0e76" + } + ] + }, + "0xcdAa68ce322728FE4185a60f103C194F1E2c47BC": { + "asset": "0x775F661b0bD1739349b9A2A3EF60be277c5d2D29", + "name": "ERC4626RateProvider", + "summary": "safe", + "review": "./MarketRateTransformerRateProviders.md", + "warnings": [""], + "factory": "0xeC2C6184761ab7fE061130B4A7e3Da89c72F8395", + "upgradeableComponents": [ + { + "entrypoint": "0x775F661b0bD1739349b9A2A3EF60be277c5d2D29", + "implementationReviewed": "0x23db508559ca053eee7f21b94dac803353560b4f" + }, + { + "entrypoint": "0x87870Bca3F3fD6335C3F4ce8392D69350B4fA4E2", + "implementationReviewed": "0xeF434E4573b90b6ECd4a00f4888381e4D0CC5Ccd" + } + ] + }, + "0x9CC54cb63E61c7D5231c506e4206Eb459250D2A7": { + "asset": "0xbEEFC01767ed5086f35deCb6C00e6C12bc7476C1", + "name": "ERC4626RateProvider", + "summary": "safe", + "review": "./MarketRateTransformerRateProviders.md", + "warnings": [""], + "factory": "0xeC2C6184761ab7fE061130B4A7e3Da89c72F8395", + "upgradeableComponents": [ + { + "entrypoint": "0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559", + "implementationReviewed": "0x2954c85e7e2b841d0e9a9fdcc09dac1274057d71" + }, + { + "entrypoint": "0xbdC7c08592Ee4aa51D06C27Ee23D5087D65aDbcD", + "implementationReviewed": "0x752d55d62a94658eac08eae42deda902b69b0e76" + } + ] } }, "fantom": { @@ -2067,6 +2121,24 @@ "implementationReviewed": "0xF2C312BfAF4CF0429DB4DA15a0cf5F770Ea3E770" } ] + }, + "0x30EAcEC6BD250589043De026e45dc9A158C65a1F": { + "asset": "0x773CDA0CADe2A3d86E6D4e30699d40bB95174ff2", + "name": "ERC4626RateProvider", + "summary": "safe", + "review": "./MarketRateTransformerRateProviders.md", + "warnings": [""], + "factory": "0x03362f847b4fabc12e1ce98b6b59f94401e4588e", + "upgradeableComponents": [ + { + "entrypoint": "0x773CDA0CADe2A3d86E6D4e30699d40bB95174ff2", + "implementationReviewed": "0x7CB7fdeEB5E71f322F8E39Be67959C32a6A3aAA3" + }, + { + "entrypoint": "0xb50201558B00496A145fE76f7424749556E326D8", + "implementationReviewed": "0xF2C312BfAF4CF0429DB4DA15a0cf5F770Ea3E770" + } + ] } }, "mode": { diff --git a/rate-providers/wUSDLPaxosRateProvider.md b/rate-providers/wUSDLPaxosRateProvider.md index 7c374a7..c55e7d7 100644 --- a/rate-providers/wUSDLPaxosRateProvider.md +++ b/rate-providers/wUSDLPaxosRateProvider.md @@ -5,6 +5,7 @@ - Checked by: @danielmkm - Deployed at: - [arbitrum:0x4d494eF5CB1143991F7F767567aD7f55bCfDc279](https://arbiscan.io/address/0x4d494eF5CB1143991F7F767567aD7f55bCfDc279#code) + - [ethereum:0x51b7F50044a2a1A9A846575Be33c00A68e0172DF](https://etherscan.io/address/0x51b7F50044a2a1A9A846575Be33c00A68e0172DF#code) - Audit report(s): - [USDL audits](https://github.com/paxosglobal/ybs-contract/blob/master/audits/REP-final-20240301T145234Z.pdf) @@ -35,6 +36,16 @@ If none of these is checked, then this might be a pretty great Rate Provider! If - admin address: [arbitrum:0x0E5087e19EB58e28DDF9F341b550BE6797547BF7](https://arbiscan.io/address/0x0E5087e19EB58e28DDF9F341b550BE6797547BF7#code) - admin type: multisig - multisig threshold/signers: 3/17 + +Ethereum: + - upgradeable component: `wYBSV1` ([ethereum:0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559](https://etherscan.io/address/0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559#readProxyContract)) + - admin address: [ethereum:0x60Be07b68214d49aF3Ec8fa89c7fc0970De0A94E](https://etherscan.io/address/0x60Be07b68214d49aF3Ec8fa89c7fc0970De0A94E#code) + - admin type: multisig + - multisig threshold/signers: 3/20 + - upgradeable component: `YBSV1` ([ethereum:0xbdC7c08592Ee4aa51D06C27Ee23D5087D65aDbcD](https://etherscan.io/address/0xbdC7c08592Ee4aa51D06C27Ee23D5087D65aDbcD#code)) + - admin address: [ethereum:0x65bcf790Cb8ADf60D5f54eC2E10DE8C83886E0AE](https://etherscan.io/address/0x65bcf790Cb8ADf60D5f54eC2E10DE8C83886E0AE#code) + - admin type: multisig + - multisig threshold/signers: 3/17 ### Oracles From c6b61012b9b813e3bf77e10d861946d55dec7645 Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Wed, 11 Dec 2024 07:53:22 +0100 Subject: [PATCH 2/3] style: formatting --- rate-providers/registry.json | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/rate-providers/registry.json b/rate-providers/registry.json index c49b304..247992c 100644 --- a/rate-providers/registry.json +++ b/rate-providers/registry.json @@ -2187,9 +2187,10 @@ "factory": "0x0767bECE12a327A1eD896c48E843AE53a0c313E9", "upgradeableComponents": [ { - "entrypoint": "0xA61BeB4A3d02decb01039e378237032B351125B4", - "implementationReviewed": "0x5adDc89785D75C86aB939E9e15bfBBb7Fc086A87" - }] + "entrypoint": "0xA61BeB4A3d02decb01039e378237032B351125B4", + "implementationReviewed": "0x5adDc89785D75C86aB939E9e15bfBBb7Fc086A87" + } + ] }, "0xFE1862BdCAf17ADf2D83eEb0Da98dAE04492F4f7": { "asset": "0x90993Ac1734b023dEEc548b87B11F5d2dcD3818E", @@ -2200,9 +2201,10 @@ "factory": "", "upgradeableComponents": [ { - "entrypoint": "0xA2aa501b19aff244D90cc15a4Cf739D2725B5729", - "implementationReviewed": "0xEbe57e8045F2F230872523bbff7374986E45C486" - }] + "entrypoint": "0xA2aa501b19aff244D90cc15a4Cf739D2725B5729", + "implementationReviewed": "0xEbe57e8045F2F230872523bbff7374986E45C486" + } + ] }, "0xFAD2f1b6B24d475BAA79DfA625073981bCD82A0e": { "asset": "0x80137510979822322193FC997d400D5A6C747bf7", @@ -2213,9 +2215,10 @@ "factory": "", "upgradeableComponents": [ { - "entrypoint": "0xA2aa501b19aff244D90cc15a4Cf739D2725B5729", - "implementationReviewed": "0xEbe57e8045F2F230872523bbff7374986E45C486" - }] + "entrypoint": "0xA2aa501b19aff244D90cc15a4Cf739D2725B5729", + "implementationReviewed": "0xEbe57e8045F2F230872523bbff7374986E45C486" + } + ] } }, "optimism": { From cc5c42ad2c6ab0af6714cdd1ab21bb6577dffa89 Mon Sep 17 00:00:00 2001 From: mkflow27 Date: Wed, 11 Dec 2024 07:53:43 +0100 Subject: [PATCH 3/3] review: more info on upgradeability --- .../MarketRateTransformerRateProviders.md | 41 +++++++++++++------ 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/rate-providers/MarketRateTransformerRateProviders.md b/rate-providers/MarketRateTransformerRateProviders.md index fe0daa6..4582f1c 100644 --- a/rate-providers/MarketRateTransformerRateProviders.md +++ b/rate-providers/MarketRateTransformerRateProviders.md @@ -5,19 +5,27 @@ - Checked by: @danielmkm - Deployed at: - Lido a-wstETH [ethereum:0xcdAa68ce322728FE4185a60f103C194F1E2c47BC](https://etherscan.io/address/0xcdAa68ce322728FE4185a60f103C194F1E2c47BC#code) + - ERC4626RateProvider: aave wsteth market + - ERC4626Vault's `asset` rate provider: Wrapped Staked Eth + - csUSDL (Steakhouse) [ethereum:0x9CC54cb63E61c7D5231c506e4206Eb459250D2A7](https://etherscan.io/address/0x9CC54cb63E61c7D5231c506e4206Eb459250D2A7#code) + - ERC4626RateProvider: MetaMorpho + - ERC4626Vault's `asset` rate provider: Wrapped USDL (wUSDL) ERC4626 Rate Provider - a-wstETH [gnosis:0x30EAcEC6BD250589043De026e45dc9A158C65a1F](https://gnosisscan.io/address/0x30EAcEC6BD250589043De026e45dc9A158C65a1F#readContract) + - ERC4626RateProvider: aave wsteth market + - ERC4626Vault's `asset` rate provider: Wrapped Staked Eth - Audit report(s): - [Formal Verification Report For StaticAToken](https://github.com/aave-dao/aave-v3-origin/blob/067d29eb75115179501edc4316d125d9773f7928/audits/11-09-2024_Certora_StataTokenV2.pdf) - - [Security Reviews & Formal Verifications](https://docs.morpho.org/security-reviews/) - [MetaMorpho Spearbit Audit](https://github.com/morpho-org/metamorpho/blob/main/audits/2023-11-14-metamorpho-cantina-managed-review.pdf) ## Context +Aave markets Lido a-wstETH & a-wstETH The ERC4626 RateProvider fetches the rate of Static Aave Tokens in terms of USDC or USDT. The exchange rate is provided by the Aave V3 `POOL` and fetched via `getReserveNormalizedIncome` from the pool and wrapped as part of the `convertToAsset` call to the `StataTokenV2`. +csUSDL The ERC4626 RateProvider fetches the rate of MetaMorpho Vault tokens in terms of the underlying asset. The exchange rate is provided via the conversion between totalAssets and totalSupply. The Morpho contract only determines the potential market parameters, assets, collaterals, beneficiary, owner, fee, and cooldown periods related to the vault curator. There are no entry or exit fees, and no time locks for users to deposit and withdraw from this vault. ## Review Checklist: Bare Minimum Compatibility @@ -36,6 +44,7 @@ If none of these is checked, then this might be a pretty great Rate Provider! If - [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). + #### Wrapped Aave Ethereum Lido wstETH - [ethereum:0x775F661b0bD1739349b9A2A3EF60be277c5d2D29](https://etherscan.io/address/0x775F661b0bD1739349b9A2A3EF60be277c5d2D29#code) - upgradeable component: `StataTokenV2` ([ethereum:0xD4fa2D31b7968E448877f69A96DE69f5de8cD23E](https://etherscan.io/address/0xD4fa2D31b7968E448877f69A96DE69f5de8cD23E#readProxyContract)) - admin address: [ethereum:0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A](https://etherscan.io/address/0x5300A1a15135EA4dc7aD5a167152C01EFc9b192A#code) @@ -46,7 +55,7 @@ If none of these is checked, then this might be a pretty great Rate Provider! If - admin type: Aave governance system. - multisig timelock? YES: 24 hours - + #### Wrapped Aave Gnosis wstETH - [gnosis:0x773CDA0CADe2A3d86E6D4e30699d40bB95174ff2](https://gnosisscan.io/address/0x773CDA0CADe2A3d86E6D4e30699d40bB95174ff2#readProxyContract) - upgradeable component: `StataTokenV2` ([gnosis:0x51350d88c1bd32Cc6A79368c9Fb70373Fb71F375](https://gnosisscan.io/address/0x51350d88c1bd32Cc6A79368c9Fb70373Fb71F375.#readProxyContract)) - admin address: [gnosis:0x1dF462e2712496373A347f8ad10802a5E95f053D](https://gnosisscan.io/address/0x1dF462e2712496373A347f8ad10802a5E95f053D) @@ -57,16 +66,22 @@ If none of these is checked, then this might be a pretty great Rate Provider! If - admin type: Aave governance system. - multisig timelock? YES: 24 hours -For Morpho: -- [x] Some other portion of the price pipeline is upgradeable (e.g., the token itself, an oracle, or some piece of a larger system that tracks the price). - Part of the rate computation relies of `totalAssets` being calculated. This function iterates over a list of Ids. This list of Ids can be changed by the Allocator role. The potential impact has not been thoroughly investigated. There are however protections in place to protect against invalid changes such as - - `revert ErrorsLib.DuplicateMarket(id);` - - `revert ErrorsLib.InvalidMarketRemovalNonZeroCap(id);` - - `revert ErrorsLib.PendingCap(id);` - - `ErrorsLib.InvalidMarketRemovalNonZeroSupply(id);` - - `ErrorsLib.InvalidMarketRemovalTimelockNotElapsed(id);` - -See /MorphoERC4626RateProviders + #### Coinshift USDL (csUSDL) + The Metamorpho Vault + - Part of the rate computation relies of `totalAssets` being calculated. This function iterates over a list of Ids. This list of Ids can be changed by the Allocator role. The potential impact has not been thoroughly investigated. There are however protections in place to protect against invalid changes such as + - `revert ErrorsLib.DuplicateMarket(id);` + - `revert ErrorsLib.InvalidMarketRemovalNonZeroCap(id);` + - `revert ErrorsLib.PendingCap(id);` + - `ErrorsLib.InvalidMarketRemovalNonZeroSupply(id);` + - `ErrorsLib.InvalidMarketRemovalTimelockNotElapsed(id);` + - Also take into account the vaultAssetPriceFeed. This was investigated as part of the [review](./wUSDLPaxosRateProvider.md) with the upgradeable component: `wYBSV1` ([ethereum:0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559](https://etherscan.io/address/0x7751E2F4b8ae93EF6B79d86419d42FE3295A4559#readProxyContract)) + - admin address: [ethereum:0x60Be07b68214d49aF3Ec8fa89c7fc0970De0A94E](https://etherscan.io/address/0x60Be07b68214d49aF3Ec8fa89c7fc0970De0A94E#code) + - admin type: multisig + - multisig threshold/signers: 3/20 + - upgradeable component: `YBSV1` ([ethereum:0xbdC7c08592Ee4aa51D06C27Ee23D5087D65aDbcD](https://etherscan.io/address/0xbdC7c08592Ee4aa51D06C27Ee23D5087D65aDbcD#code)) + - admin address: [ethereum:0x65bcf790Cb8ADf60D5f54eC2E10DE8C83886E0AE](https://etherscan.io/address/0x65bcf790Cb8ADf60D5f54eC2E10DE8C83886E0AE#code) + - admin type: multisig + - multisig threshold/signers: 3/17 ### Oracles - [ ] Price data is provided by an off-chain source (e.g., a Chainlink oracle, a multisig, or a network of nodes). @@ -77,7 +92,7 @@ See /MorphoERC4626RateProviders - [ ] The Rate Provider is susceptible to donation attacks. ## Conclusion -**Summary judgment: SAFE/USBALE** +**Summary judgment: USABLE** The Rate Providers should work well with Balancer pools. The underlying contracts have been audited and been in production for an extended period of time. The upgradeability of the underlying Aave protocol is guarded behind decentralized governance and has a minimum execution delay of 24 hours.