Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct-approval router #1200

Open
jubeira opened this issue Dec 23, 2024 · 1 comment
Open

Direct-approval router #1200

jubeira opened this issue Dec 23, 2024 · 1 comment

Comments

@jubeira
Copy link
Contributor

jubeira commented Dec 23, 2024

Some integrators can't use permit2, and would rather granting approvals to the routers directly.

One option would be to reuse existing code, add an immutable flag that can be configured during construction time, and use permit2 or direct transferFroms depending on it.

@jubeira
Copy link
Contributor Author

jubeira commented Jan 7, 2025

Let's start with a transfer-first router, only for swaps exact in.

The aggregator pays upfront, then calls the router and gets the tokens owed. No approvals needed at all.

Use #727 as a base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant