Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOR - Core Logic - Fix seenPools #876

Open
brunoguerios opened this issue Aug 30, 2024 · 0 comments
Open

SOR - Core Logic - Fix seenPools #876

brunoguerios opened this issue Aug 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@brunoguerios
Copy link
Member

brunoguerios commented Aug 30, 2024 •
edited
Loading

seenPools logic seems broken within SOR core logic

  1. isValidPath -> seenPoolAddresses is doing nothing
  • logic seems to have been moved to sortAndFilterPaths, so we should be able to remove it from here
  1. sortAndFilterPaths filtering out pools already seen on other paths is not necessarily optimal, right?
  • my assumption is that it's possible that a stable/ECLP pool with lower swapLimit may provide a better trade than a weighted pool with higher swap limit
@brunoguerios brunoguerios added the bug Something isn't working label Aug 30, 2024
@brunoguerios brunoguerios changed the title SOR - Fix seenPools logic SOR - Core Logic - Fix seenPools Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brunoguerios