New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FX - support dynamic fees24 in snapshots #1182

Open

gmbronco opened this issue Nov 22, 2024 · 0 comments

Collaborator

gmbronco commented Nov 22, 2024

context: #1101

Don't we also need to update how the fees24h is computed in pool.snapshot-service.ts? (note: this file seems to exist in two places)

The code assumes a static pool swap fee, but FX pools have a dynamic swap fee

fees24h: volume24h * parseFloat(poolAtBlock.swapFee)
I'm thinking something like this might work:

fees24h: parseFloat(pool.totalSwapFee) - parseFloat(pool24hAgo.totalSwapFee)

gmbronco mentioned this issue

adding dynamic swap fee to fx pools #1101

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment