You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey team, we already have the nested pool removals working (not yet merged) but I have a DX question:
The Base query output for Remove Liquidity has this type:
signRemoveLiquidityApproval and signRemoveLiquidityBoostedApproval use RemoveLiquidityBaseBuildCallInput which in turn uses RemoveLiquidityBaseQueryOutput, so the will both expect bptIn: TokenAmount as an input parameter
However, signRemoveLiquidityNestedApproval
expects bptAmountIn: TokenAmount;
which breaks the TS contract a little bit.
Our code is working by using a little TS casting but it feels dirty and could be confusing for other integrators.
If you have time it would be nice to rename from bptAmountIn to bptIn (If I’m not missing something important)
The text was updated successfully, but these errors were encountered:
We should keep consistency between bptIn and bptAmountIn throughout the code.
This is a report from @agualis:
The text was updated successfully, but these errors were encountered: