Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Proportional Amounts rounding direction #388

Open
brunoguerios opened this issue Aug 13, 2024 · 2 comments
Open

Calculate Proportional Amounts rounding direction #388

brunoguerios opened this issue Aug 13, 2024 · 2 comments
Assignees

Comments

@brunoguerios
Copy link
Member

Both v2 and v3 have different calculateProportionalAmounts for amounts in or out.

Should we consider adapting b-sdk to follow that based on how/where calculateProportionalAmounts is used?

e.g. following that logic, RemoveLiquidityRecovery should round down results

@johngrantuk
Copy link
Member

@brunoguerios - you've handled this now right?

@brunoguerios
Copy link
Member Author

No. I handled cow-amm proportional math. This issue is meant to replicate the approach for v2 and v3 proportional math (i.e. the other helper method)

@brunoguerios brunoguerios self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants