Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output of kpops generate doesn't pass schema validation #381

Closed
disrupted opened this issue Oct 30, 2023 · 0 comments · Fixed by #392
Closed

Output of kpops generate doesn't pass schema validation #381

disrupted opened this issue Oct 30, 2023 · 0 comments · Fixed by #392
Assignees
@disrupted
Labels
component/generator Related to the generation of pipeline.yaml type/bug Something isn't working

Comments

@disrupted
Copy link
Member

kpops generate writes the enriched pipeline as

components:
  - type: ...
  - ...

this means, it violates our schema. The components key is an implementation detail that should be hidden.
@disrupted disrupted added component/generator Related to the generation of pipeline.yaml type/bug Something isn't working labels Oct 30, 2023
@disrupted disrupted self-assigned this Oct 31, 2023
disrupted added a commit that referenced this issue Dec 7, 2023
@disrupted
Use pydantic.RootModel for PipelineComponents
6582e34 
Fixes #381
@disrupted disrupted mentioned this issue Dec 7, 2023
Merged
disrupted added a commit that referenced this issue Dec 20, 2023
@disrupted
Refactor pipeline generator & representation (#392)
f95afe2 
Fixes #381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disrupted disrupted

Labels
component/generator Related to the generation of pipeline.yaml type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor pipeline generator & representation bakdata/kpops
1 participant
@disrupted