Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate HelmApp component #364

Closed
disrupted opened this issue Sep 27, 2023 · 0 comments · Fixed by #370
Closed

Create separate HelmApp component #364

disrupted opened this issue Sep 27, 2023 · 0 comments · Fixed by #370
Assignees
@disrupted
Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Milestone
v3.0

Comments

@disrupted
Copy link
Member

The builtin KubernetesApp component should be generic – not be specific to Helm. We should create a HelmApp component that inherits from KubernetesApp
@disrupted disrupted added breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality labels Sep 27, 2023
@disrupted disrupted added this to the v3.0 milestone Sep 27, 2023
@disrupted disrupted self-assigned this Oct 11, 2023
@disrupted disrupted mentioned this issue Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disrupted disrupted

Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Create HelmApp component bakdata/kpops
1 participant
@disrupted