Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return td/tr attributes when parsing #1

Open
tacman opened this issue Feb 16, 2024 · 3 comments
Open

return td/tr attributes when parsing #1

tacman opened this issue Feb 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tacman
Copy link

tacman commented Feb 16, 2024

Feature Request

Q A
New Feature yes
BC Break no

Proposal

I'd like to see the tr/td attributes. I'm parsing a table where the key id is never displayed.

<tr class="table-data-styles">
        <td data-event="842349">08-25-23</td>
        <td class="time">07:00 PM</td>
        <td>Game</td>
</tr>

If this already exists, can you point me to the docs? Thanks, cool library, I've worked on variations of this over the years and have always hoped someone else would write it! And it's integrated with league/csv!

@nyamsprod
Copy link
Member

nyamsprod commented Feb 18, 2024

@tacman currently this feature is not available... might be something to look into if you can provide a PR I would gladly review it and incorporate it to the library

@nyamsprod nyamsprod added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2024
@nyamsprod nyamsprod self-assigned this Feb 18, 2024
@tacman
Copy link
Author

tacman commented Feb 18, 2024

can you point me/anyone reading this to where in the code the td is parsed and what structure you'd recommend for the attributes?

@nyamsprod
Copy link
Member

nyamsprod commented Feb 18, 2024

I believe you should first think about how it will be done/shown to the consumer of the library before thinking about the implementation. my 2 cents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants