Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different initialization patterns #48

Closed
jessicasyu opened this issue Oct 4, 2024 · 0 comments · Fixed by #81
Closed

Add support for different initialization patterns #48

jessicasyu opened this issue Oct 4, 2024 · 0 comments · Fixed by #81
Assignees
Labels
category: env Related to the env subpackages package: patch Related to the patch implementation type: feature Improvement or additions to the code base

Comments

@jessicasyu
Copy link
Member

Current patch initialization will initialize cells starting from the center of the environment outward. We should support random and inward initialization. Random initialization will be useful for #40.

Proposal:

  1. Add a new patch level parameter called INITIALIZATION_STRATEGY
  2. Update the createLocations method in PatchLocationFactory to handle the different strategies:
    • random = shuffle the locations list only
    • outward = shuffle the locations list, then sort by distance (the current implementation)
    • inward = shuffle the locations list, sort by distance, then reverse the list
@jessicasyu jessicasyu added category: env Related to the env subpackages package: patch Related to the patch implementation type: feature Improvement or additions to the code base labels Oct 4, 2024
@jessicasyu jessicasyu self-assigned this Oct 10, 2024
@jessicasyu jessicasyu linked a pull request Oct 24, 2024 that will close this issue
@cainja cainja closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: env Related to the env subpackages package: patch Related to the patch implementation type: feature Improvement or additions to the code base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants