Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cypress video #10829

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix: cypress video #10829

merged 1 commit into from
Jan 18, 2025

Conversation

jNullj
Copy link
Member

@jNullj jNullj commented Jan 17, 2025

Fixes #10828

Cypress v13 had breaking changes where the default value for video and videoCompression changed from true to false.
This re-adds video using the cypress config as mentioned in the migration docs

Fixes badges#10828

Cypress v13 had breaking changes where the default value for video and videoCompression changed from true to false.
This re-adds video using the cypress config as mentioned in the migration [docs](https://docs.cypress.io/app/references/migration-guide#Migrating-to-Cypress-130)
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 3484a5d

@jNullj
Copy link
Member Author

jNullj commented Jan 17, 2025

Very cool, it just works
example in this actions run with logs (it picked 32 CRF for compression, its 200KiB~)
screenshots are automatics on failure.

Video for fun
https://github.com/user-attachments/assets/74125e5f-326e-4f16-8c3b-7567c5cc2ccb

@jNullj jNullj marked this pull request as ready for review January 17, 2025 22:13
@jNullj jNullj added the developer-experience Dev tooling, test framework, and CI label Jan 17, 2025
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@jNullj jNullj added this pull request to the merge queue Jan 18, 2025
Merged via the queue into badges:master with commit 2c089f7 Jan 18, 2025
24 checks passed
@jNullj jNullj deleted the jNullj/issue10828 branch January 18, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: cypress video and screenshot missing
2 participants