Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow [chromewebstore] size to contain decimal point #10812

Merged
merged 4 commits into from
Jan 18, 2025
Merged

allow [chromewebstore] size to contain decimal point #10812

merged 4 commits into from
Jan 18, 2025

Conversation

chris48s
Copy link
Member

Closes #10811

@chris48s chris48s added bug Bugs in badges and the frontend service-badge New or updated service badge labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Warnings
⚠️ This PR modified service code for chrome-web-store but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against ffac497

jNullj
jNullj requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve here a bit.

services/chrome-web-store/chrome-web-store-size.service.js Outdated Show resolved Hide resolved
services/chrome-web-store/chrome-web-store-size.spec.js Show resolved Hide resolved
jNullj
jNullj approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris48s chris48s added this pull request to the merge queue Jan 18, 2025
Merged via the queue into badges:master with commit 49bcb52 Jan 18, 2025
23 checks passed
@chris48s chris48s deleted the 10811-webstore-size branch January 18, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jNullj jNullj jNullj approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome Web Store Size size does not match expected format
2 participants
@chris48s @jNullj