Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badger Firefox fails on read.cash #215

Open
readcash opened this issue Nov 26, 2019 · 7 comments
Open

Badger Firefox fails on read.cash #215

readcash opened this issue Nov 26, 2019 · 7 comments

Comments

@readcash
Copy link

Describe the bug
Trying to log in with Badger Wallet Firefox results in this:

image

To Reproduce
Steps to reproduce the behavior:

  1. Use Badger on Firefox (Mac or reported by user on Ubuntu too)
  2. Go to http://read.cash/register
    unlock Badger
  3. Click "Badger Wallet"
  4. Click sign
    ... no error is shown, but console shows error.

Expected behavior

  1. It should show an error to user
    or
  2. It should log in (Badger Chrome works fine), on our side we see only OPTIONS request that results in 200 response. Same server works fine on Badger Chrome.

Screenshots
image

@SpendBCH
Copy link
Collaborator

SpendBCH commented Dec 7, 2019

Hi,

This might be a difference between how Chrome and Firefox handle certain requests, can you you try again in Firefox with an https address?

Thanks!

@GitCash 1000 bits for @readcash

@GitCash
Copy link

GitCash commented Dec 7, 2019

Hey readcash, user SpendBCH tipped you 1000 bits in Bitcoin Cash ( ~ $0.212 ).

Click here to claim it!

You can also add the "thumbs down" reaction to SpendBCH's comment above to prevent future tips.

@readcash
Copy link
Author

readcash commented Dec 7, 2019

So far, it's the same!

Badger shows Version 0.7.9 - is this the right version to try or do I need to update it?

Thanks for the tip! :) It'll go towards supporting the authors at https://read.cash

@readcash
Copy link
Author

readcash commented Dec 7, 2019

the tip... It'll go towards supporting the authors at https://read.cash

...or maybe not (see the issues above) 🤷‍♂

@readcash
Copy link
Author

readcash commented Dec 7, 2019

You can probably try it yourself - it's like 4 clicks: https://read.cash/register -> Understood -> Badger -> Sign

@SpendBCH
Copy link
Collaborator

SpendBCH commented Dec 7, 2019

Thanks for trying that update, looking into this more it looks like a CORS issue.

Could you please try enabling CORS on your server -- the issue is the request does not come from your own domain and Firefox will reject it.

Hopefully deposits will start going through again soon, gitcash is a great service.

@readcash
Copy link
Author

readcash commented Dec 7, 2019

Yep, CORS fixes it. Thanks! Can I ask you to add try/catch and an error to badger?... it's really confusing, seems like "nothing is happening" and I'm sure as Badger gets more popular - similar issues will popup (CORS without any error). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants