Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use URL searchParams when construction in getAuthorizeUri #124

Open
WeeJeWel opened this issue Sep 28, 2023 · 0 comments
Open

Use URL searchParams when construction in getAuthorizeUri #124

WeeJeWel opened this issue Sep 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@WeeJeWel
Copy link

Google requires ?access_type=offline in the authorization url:

https://accounts.google.com/o/oauth2/auth?access_type=offline&prompt=consent

This library concats ?client_id= which leads to two ?.

A more elegant way would be to use new URL() and then .searchParams.append('client_id', ...).
@evert evert added the bug Something isn't working label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evert @WeeJeWel